chore(snmp-discovery): bump diode-sdk-go to v1.10.0 in snmp-discovery#432
Merged
Conversation
Pick up auth backoff on 429/5xx and aligned User-Agent headers shipped in diode-sdk-go v1.10.0, complementing the snmp ingest queue work. Co-authored-by: Cursor <cursoragent@cursor.com>
jajeffries
requested review from
MicahParks,
davidlanouette,
grant-nbl,
leoparente,
manrodrigues,
marc-barry,
mfiedorowicz,
paulstuart and
samiura
as code owners
Contributor
Author
|
@codex review |
jajeffries
changed the title
jajeffries
changed the title
Vulnerability Scan: PassedImage: No vulnerabilities found. Commit: cf5aef3 |
|
Go test coverage
Total coverage: 87.8% |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump
snmp-discoverytodiode-sdk-gov1.10.0 so the released backend picks up auth backoff on 429/5xx (OBS-3341) and aligned User-Agent headers (OBS-3342), complementing the ingest queue work in #419.What changed
orb-discovery/snmp-discovery/go.mod/go.sum:diode-sdk-gov1.9.0 → v1.10.0How tested
cd orb-discovery/snmp-discovery && go test ./...make fix-lintmake agent_fast(localnetboxlabs/orb-agent:developimage)make clab-test— 5/5 protocol smoke checks passedORB_AGENT_IMAGE=netboxlabs/orb-agent:develop make clab-discover— snmp_discovery, device_discovery, and network_discovery dry-run JSON written toclab/out/Linear
OBS-3341 — https://linear.app/netboxlabs/issue/OBS-3341/diode-sdk-go-add-backoff-on-auth-for-4295xx-responses
OBS-3342 — https://linear.app/netboxlabs/issue/OBS-3342/diode-sdk-go-align-user-agent-with-python-sdk
Made with Cursor