Move to function-avd v0.1.6, whose topology names no registry - #35
Merged
Conversation
Upstream now generates `examples/lab/topology.yaml` with a plain `ceos:4.36.1F`. That is the name `docker import` + `kind load` leaves, so the fabric page no longer has to rewrite the file it just downloaded -- the topology matches the image the documentation told the reader to load. The ref moves in both places that carry it, because they must not disagree: the design read by the overlay and the topology fetched by the bring-up script come from one tag on purpose, since a push to a device that is not running never converges. scripts/up.sh serves cEOS from the local registry rather than from the node, so it takes over the rewrite -- against its temp copy, with the tag still read from the topology so the AVD model keeps deciding the EOS version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
function-avd #22 generates
examples/lab/topology.yamlwith a plainceos:4.36.1Finstead oflocalhost:5001/netclab/ceos:4.36.1F.That address was only ever correct on a machine running a bring-up script, and the fabric page had to undo it with
yqright after downloading the file. Now the topology names the image the documentation already told the reader to load, and that paragraph goes away.?ref=in the overlay andAVD_REFinscripts/up.shboth move tov0.1.6— they select the design and the devices respectively and must not disagreescripts/up.sh, which serves cEOS from the local registry, takes over the rewrite against its temp copy; the tag is still read from the topology, so the AVD model keeps deciding the EOS versionChecked: the topology at
v0.1.6namesceos:4.36.1F, the rewrite produces the registry address,bash -nandmkdocs build --strictpass.🤖 Generated with Claude Code