Skip to content

[NAE-2369] Remove global functions of cache#410

Merged
machacjozef merged 1 commit intorelease/7.0.0-rev10from
NAE-2369
Feb 4, 2026
Merged

[NAE-2369] Remove global functions of cache#410
machacjozef merged 1 commit intorelease/7.0.0-rev10from
NAE-2369

Conversation

@renczesstefan
Copy link
Member

@renczesstefan renczesstefan commented Feb 4, 2026

Description

Implements NAE-2369

Dependencies

No new dependencies introduced.

Third party dependencies

No new dependencies were introduced.

Blocking Pull requests

There are no dependencies on other PR.

How Has Been This Tested?

This was tested manually and with unit tests.

Test Configuration

Name Tested on
OS macOS Tahoe 26.2
Runtime Java 21
Dependency Manager Maven 3.9.9n
Framework version Spring Boot 3.4.4
Run parameters
Other configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @machacjozef
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides
    • Migration Guides

Summary by CodeRabbit

  • Refactor
    • Optimized internal cache management for process functions to improve application performance through more efficient cache invalidation strategies.

Replaced `reloadCachedGlobalFunctions` with a new method `removeCachedPetriNetFunctions` in `PetriNetService` and adjusted its usage to improve cache management. Updated the `FieldActionsCacheService` to evict specific cache entries more explicitly, ensuring proper cleanup.
@coderabbitai
Copy link

coderabbitai bot commented Feb 4, 2026

Walkthrough

Changes the cache invalidation strategy for PetriNet deletion from broad global function reload to targeted removal of specific PetriNet functions. Introduces a new removal method in the cache service and updates related method signatures to support this more efficient approach.

Changes

Cohort / File(s) Summary
Cache Invalidation Strategy
PetriNetService.deletePetriNet, FieldActionsCacheService.reloadCachedGlobalFunctions
Refactors cache invalidation to use targeted removal by PetriNet ID instead of reloading all global functions, improving efficiency while maintaining existing behavior.
Cache Service Interface & Implementation
FieldActionsCacheService, IFieldActionsCacheService
Adds new public method removeCachedPetriNetFunctions(String processIdentifier) for evicting specific PetriNet functions from the GLOBAL_FUNCTIONS cache. Renames parameter in reloadCachedGlobalFunctions from petriNetId to processIdentifier for consistency.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

bugfix, Medium

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: introducing a targeted cache removal mechanism for global functions instead of broad reloads, which aligns with the PR's core objective.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai bot added bugfix A change that fixes a bug Medium labels Feb 4, 2026
@machacjozef machacjozef merged commit ff58d01 into release/7.0.0-rev10 Feb 4, 2026
7 checks passed
@machacjozef machacjozef deleted the NAE-2369 branch February 4, 2026 15:18
@coderabbitai coderabbitai bot mentioned this pull request Feb 5, 2026
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix A change that fixes a bug Medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants