Skip to content

feat(docker): HEALTHCHECK against /info - #263

Merged
CybotTM merged 1 commit into
mainfrom
feat-dockerfile-healthcheck
Aug 13, 2026
Merged

feat(docker): HEALTHCHECK against /info#263
CybotTM merged 1 commit into
mainfrom
feat-dockerfile-healthcheck

Conversation

@CybotTM

@CybotTM CybotTM commented Aug 13, 2026

Copy link
Copy Markdown
Member

Ops finding from the 2026-W33 maintenance QA (NRT-4584, internal): docker ps shows no health state for raybeam — the image defines no HEALTHCHECK, so post-deploy verification falls back to uptime and restart counts, while sibling services (ldap-manager, node-red) report (healthy) from their image-level checks.

Alpine base ships busybox wget; /info is unauthenticated, cheap, and proves the HTTP stack + config load. Port 8080 is the documented serve default used by every known deployment.

Verified against the running 1.1.0 container that wget -q -O /dev/null http://127.0.0.1:8080/info succeeds in-container.

Ops finding from the 2026-W33 maintenance QA (NRT-4584): the container
reports no health state, so 'healthy' cannot be asserted machine-side after
deploys — reviewers fell back to uptime+restart-count. Alpine base ships
busybox wget; /info is unauthenticated and proves the HTTP stack is up.

Signed-off-by: Sebastian Mendel <sebastian.mendel@netresearch.de>
Copilot AI lite review requested due to automatic review settings August 13, 2026 08:26
@sonarqubecloud

sonarqubecloud Bot commented Aug 13, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions github-actions Bot added the dependencies Pull requests that update a dependency file label Aug 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.70%. Comparing base (c7b75dd) to head (91f9823).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #263   +/-   ##
=======================================
  Coverage   74.70%   74.70%           
=======================================
  Files          10       10           
  Lines         427      427           
=======================================
  Hits          319      319           
  Misses         88       88           
  Partials       20       20           
Flag Coverage Δ
e2e 74.70% <ø> (ø)
integration 74.70% <ø> (ø)
unittests 74.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated approval for maintainer PR

All automated quality gates passed. See SECURITY_CONTROLS.md for compensating controls.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@CybotTM

CybotTM commented Aug 13, 2026

Copy link
Copy Markdown
Member Author

Review record (Copilot errored twice on 91f9823 — the org-wide outage pattern seen on every repo today): manual review in lieu of the bot. The 7-line diff adds only a HEALTHCHECK: probe endpoint verified unauthenticated and cheap (/info), the exact command verified to succeed inside the RUNNING 1.1.0 container (busybox wget is present in the alpine base), port 8080 confirmed as the deployed serve port (traefik server.port label), and the comment block documents why the port is hardcoded. SonarCloud's S7026 (wget→ADD) was triaged as false positive with rationale — the rule targets build-stage downloads, a HEALTHCHECK cannot be an ADD. Quality gate now OK, 28/28 checks, github-actions approval satisfies the pull_request ruleset.

@CybotTM
CybotTM added this pull request to the merge queue Aug 13, 2026
Merged via the queue into main with commit 3f85fd5 Aug 13, 2026
29 of 31 checks passed
@CybotTM
CybotTM deleted the feat-dockerfile-healthcheck branch August 13, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants