Skip to content

ci: run the test suite - #60

Closed
CybotTM wants to merge 1 commit into
mainfrom
ci/run-the-test-suite
Closed

CybotTM wants to merge 1 commit into
mainfrom
ci/run-the-test-suite

Conversation

@CybotTM

@CybotTM CybotTM commented Aug 10, 2026

Copy link
Copy Markdown
Member

Four suites under tests/ exist, pass, and nothing executes them — lint, validate and release never touch tests/. A test no pipeline runs is not a gate; it only looks like one.

This calls the reusable added in netresearch/skill-repo-skill#211, so a fix to the runner reaches every skill repo at once instead of being copied per repo.

Context: a fleet measurement found 27 of 33 skill repos shipping scripts had no test file at all, and none of the 20 reusable workflows ran tests/. This repo is the opposite case — the tests were already written, they were simply never wired to anything.

Four suites under tests/ passed and nothing executed them — lint, validate
and release never touch tests/. A test no pipeline runs is not a gate, it
only looks like one.

Calls the reusable from netresearch/skill-repo-skill, so a fix to the runner
reaches every skill repo at once.

Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
Copilot AI lite review requested due to automatic review settings August 10, 2026 17:28
@sonarqubecloud

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@CybotTM

CybotTM commented Aug 10, 2026

Copy link
Copy Markdown
Member Author

Closing: the premise was wrong. lint.yml already calls ci-python.yml with test-command: … python -m unittest discover -s tests -v, so these four suites have been gated all along — the Python / Test job on this very PR ran them.

My check grepped the workflows for tests/ with a slash and missed -s tests. A narrowing pattern of my own making produced a finding about the world.

Merging this would run the same four tests twice per PR for no added coverage. The reusable stays the right tool where shell tests exist, which ci-python.yml cannot reach — that is the case in skill-repo-skill and automated-assessment-skill, and it is not the case here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants