Conversation
libhubbub predates the HTML5 <source>/<track> elements, so they were absent from the gperf element-type wordlist. element_type_from_name returned UNKNOWN for them and the "any other start tag" path pushed <source> onto the open-elements stack as a non-void container — the following <img> then nested inside the <source> instead of becoming its sibling under <picture>. In the standard `<source>…<img>` order (sources first, fallback img last) a downstream consumer that ignores <source> never sees the <img>, dropping the picture entirely. Add both to the wordlist so the generated perfect hash knows them (which also makes element_type_to_name answer for them), and add them to the void-element branch so they insert without being pushed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Cyril Hrubis <metan@ucw.cz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libhubbub predates the HTML5/ elements, so they were absent from the gperf element-type wordlist. element_type_from_name returned UNKNOWN for them and the "any other start tag" path pushed onto the open-elements stack as a non-void container — the following ![]()
then nested inside the instead of becoming its sibling under . In the standard never sees the ![]()
, dropping the picture entirely.
<source>…<img>order (sources first, fallback img last) a downstream consumer that ignoresAdd both to the wordlist so the generated perfect hash knows them (which also makes element_type_to_name answer for them), and add them to the void-element branch so they insert without being pushed.