build(deps): pin cmake>=4.3.4 to match build-system floor - #79
Open
drunkcoding wants to merge 1 commit into
Open
build(deps): pin cmake>=4.3.4 to match build-system floor#79drunkcoding wants to merge 1 commit into
drunkcoding wants to merge 1 commit into
Conversation
requirements.txt left cmake unpinned, so the Docker image resolved to the base image's pre-installed cmake 4.2.3 while pyproject.toml [build-system] requires cmake>=4.3.4 (#76). Pin requirements.txt to cmake>=4.3.4 so the canonical environment matches the declared build floor. Verified in Docker (8x A5000): the image now installs cmake 4.3.4, the vendored protobuf 3.13 compiles under it (via the existing CMAKE_POLICY_VERSION_MINIMUM 3.5 shim in tests/cpp/CMakeLists.txt), and the full suite passes (116 passed, 8 skipped).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pin
cmaketo>=4.3.4inrequirements.txt(was unpinned).Why
After #76 bumped
[build-system].requirestocmake>=4.3.4inpyproject.toml, the canonical Docker environment was still resolving to the PyTorch base image's pre-installed cmake 4.2.3 — becauserequirements.txtleftcmakeunpinned, so pip treated the requirement as already satisfied and never upgraded. The Dockerfile builds with--no-build-isolation, so the[build-system].requiresfloor is never consulted; the build uses whatever cmake is onPATH.Result: the project declared a need for cmake ≥ 4.3.4 but the actual build ran on 4.2.3. This aligns the environment with the declaration.
Verification
Built + tested in Docker (8× RTX A5000) from this branch:
cmake --versionin imagewhich cmake/usr/local/bin/cmakeCMAKE_POLICY_VERSION_MINIMUM 3.5shim intests/cpp/CMakeLists.txtpytest testsNo runtime behavior changes; build-input hygiene only.