Added probabilistic cleaning to SQLiteStorage - addresses Issue #83#84
Open
luke-keaweb wants to merge 17 commits intonette:masterfrom
Open
Added probabilistic cleaning to SQLiteStorage - addresses Issue #83#84luke-keaweb wants to merge 17 commits intonette:masterfrom
luke-keaweb wants to merge 17 commits intonette:masterfrom
Conversation
dg
force-pushed
the
master
branch
3 times, most recently
from
b91fc47 to
05451a0
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
184a11f to
9566d2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature - Addresses Issue SQLiteStorage does not automatically clean() expired cached items #83
BC break? no
Basically, added probabilistic garbage collection using clean() to SQLiteStorage - this matches the behaviour of FileStorage and prevents the cache database from growing beyond limit unless the dev implements a clean() method which runs periodically
Added a test but it requires PDO so it is SKIPPED by default - to actually run the test you have to include a php.ini which points Tester to the local PHP extensions. (I'm a bit rusty on the Nette Tester sorry)