-
Notifications
You must be signed in to change notification settings - Fork 64
Map 'aruba_os' to the existing 'aoscx' parser #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
there are four netmiko aruba drivers.
We need a way to differentiate between them. So instead of using the same driver as |
|
Updated as requested. |
|
|
||
| parser_map: t.Dict[str, t.Type[parser.BaseConfigParser]] = { | ||
| "arista_eos": parser.EOSConfigParser, | ||
| "aruba_aoscx": parser.ArubaConfigParser, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to rename this parser class to ArubaCXConfigParser. In Aruba, there is the legacy AOS (think Procurve and older model switches/gateways) as well as AOS-CX (newer switches and gateways. If we keep the name generic as it is today, this could add to confusion since the name Aruba on it's own does not make distinction between the two OS's.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That said, I am not sure the repurcussions of changing the parser class name. I think since we have the mapping table it might be a non-issue, but I will let others comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "aruba_aoscx": parser.ArubaConfigParser, | |
| "aruba_aoscx": parser.ArubaCXConfigParser, |
and this...
class ArubaCXConfigParser(BaseSpaceConfigParser):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but also am not sure about the repercussions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@itdependsnetworks agrees this specific update would be a 'breaking change', IMHO this shouldn't be done as part of this PR. The other changes requested have been pushed.
|
@itdependsnetworks - I've put this table together to try and help better understand the different ArubaOS Aruba Network Operating Systems Reference Table
Notes:
|
|
Thanks a ton! Side question, you show 9000 series in both AOS-CX and AOS, does that mean the same hardware can run either OS, or just an overlap in Aruba model numbers? |
Actually, I need to correct that - there's just an overlap in model numbering between Aruba product lines. They are completely different hardware platforms that cannot run each other's operating systems. 9000 Series Switches (like the 9300/9400) run AOS-CX exclusively Let me fix that in the table to avoid confusion by making the model numbers more specific. |
|
Here is the list of all aruba based mappers we have
|
|
@bradh11 I updated your table to include the lib name based on the names we have, can you confirm that is correct? Additionally, just ensuring we are in agreement that we do not need to consider the |
Procurve is effectively in the
Then if you need, throw aliases at other platform names for other libraries to "map" them... |
|
#632 will take the place of this PR. |
|
Fixed in #632 |
We have WLC's running Aruba OS which is different than Aruba AOS-CX. However when it comes to parsing the configurations, the existing Aruba parser works perfectly. This just creates the mapping for Aruba OS to use the existing Parser.