fix(services): properly parse launchctl output for status detection#21
Open
jhult wants to merge 1 commit into
Open
fix(services): properly parse launchctl output for status detection#21jhult wants to merge 1 commit into
jhult wants to merge 1 commit into
Conversation
The status check was using naive string matching on the launchctl list output instead of parsing the actual PID field. This caused services to incorrectly report as running when they were only loaded. Now properly checks the PID column where "-" indicates a stopped service and a numeric PID indicates running. feat(services): add detailed status info like brew services Display Running, Loaded, and Schedulable fields to match brew services info output. Schedulable indicates whether a stopped service is in a clean state (status 0) ready to be scheduled. Also fixed handling of services that have files but aren't loaded into launchd—these now correctly show as stopped rather than unknown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The status check was using naive string matching on the launchctl list output instead of parsing the actual PID field. This caused services to incorrectly report as running when they were only loaded. Now properly checks the PID column where "-" indicates a stopped service and a numeric PID indicates running.
feat(services): add detailed status info like brew services
Display Running, Loaded, and Schedulable fields to match brew services info output. Schedulable indicates whether a stopped service is in a clean state (status 0) ready to be scheduled. Also fixed handling of services that have files but aren't loaded into launchd—these now correctly show as stopped rather than unknown.