feat: 21 - profile command#21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
dtoo profileexisted in the CLI but did nothing (Commands::Profile(_args) => Ok(())), so users could not run standalone profiling on a file as described byspecs/21-profile-command.md. The user experience was a silent no-op command with no profile output.What does this PR change?
Implements the standalone
dtoo profilecommand path. It now resolves the input file, loads it into DuckDB (_profile_dataandtemp_results), and reuses the existing profiler module to emit JSON/CSV/HTML output to--outputor stdout.Does this change align with DESIGN.md?
Yes.
--outputis omitted.DtooError) and standard exit code mapping.What alternatives did you consider?
Profilermodule.Does this PR contain multiple unrelated changes?
No. This PR only implements feature 21 (
dtoo profilestandalone command) and adds focused tests for it.Existing PRs
Testing
cargo testpassescargo clippypasses with no warningscargo fmthas been runprofile_command::tests::profiles_csv_input_to_json_fileandprofile_command::tests::profiles_empty_csv_with_zero_rowsto verify standalone profile generation for populated and empty CSV inputs.Evaluation
dtoo profileflow via unit tests using a temp CSV with rows.dtoo profileflow via unit tests using a temp CSV header-only file (zero rows).row_count.Human review