feat: 22 - fingerprint command#22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
dtoo fingerprintexisted but did not fully matchspecs/22-fingerprint-command.mdbehavior. Specifically, output used the full input path instead of filename-only, and IO/cloud error handling was too generic for the expected standalone command UX.What does this PR change?
Completes the standalone fingerprint command behavior by:
sha256:{hex} {filename}(filename only),Does this change align with DESIGN.md?
Yes.
DtooErrorand continue to use exit code1for runtime failures.What alternatives did you consider?
main.rsdirectly. Rejected in favor of keeping logic encapsulated insrc/fingerprint.rs.Does this PR contain multiple unrelated changes?
No. All changes are directly related to standalone fingerprint command behavior.
Existing PRs
Testing
cargo testpassescargo clippypasses with no warningscargo fmthas been runfingerprint::tests::returns_file_not_found_error_for_missing_filefingerprint::tests::display_name_uses_basename_for_local_pathfingerprint::tests::display_name_uses_last_segment_for_cloud_pathEvaluation
sha256:... /full/path/to/file.parquetsha256:... file.parquetFile not found; cloud read errors are also mapped for missing credentials when identifiable.Human review