Skip to content

The two build backends disagree on whether [build].image is a template #33

Description

@wseaton

The cluster backend expands spec.image (crucible/src/build.rs:146); the github-actions backend uses it raw (crucible/src/build.rs:228). So the same manifest means different things by backend, and on the github path a templated image becomes a literal {{ ... }} in the pushed ref.

More reachable since 3e8c0d9, which made validate_builds accept templates in image. Either expand it on the github path too, or reject templates there.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions