Skip to content

feat: Add GNOME 50 compatibility and fix clearBtn variable scoping #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zakeetahawi wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −4
Open

feat: Add GNOME 50 compatibility and fix clearBtn variable scoping #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ The extension's directory name should match its uuid i.e. "openbar@neuromorph"
Note:
Please download from following GitHub branch as per your Gnome version:
- For Gnome 42-44: branch 'g42-44'
- For Gnome 45+: branch 'main'
- For Gnome 45-50: branch 'main'

You will need to restart the Gnome Shell (for manual install):

Expand Down
5 changes: 3 additions & 2 deletions openbar@neuromorph/extension.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,15 +383,16 @@ export default class Openbar extends Extension {
this.applySectionStyles(sectionList, add);

const msgHbox = msgbox.get_child_at_index(1); // hbox at botton for dnd and clear buttons
let clearBtn;
if(this.gnomeVersion < 49) {
const dndBtn = msgHbox.get_child_at_index(1);
this.applyMenuClass(dndBtn, add);
const toggleSwitch = dndBtn.get_child_at_index(0);
this.applyMenuClass(toggleSwitch, add);
const clearBtn = msgHbox.get_child_at_index(2);
clearBtn = msgHbox.get_child_at_index(2);
}
else {
const clearBtn = msgHbox.get_child_at_index(1);
clearBtn = msgHbox.get_child_at_index(1);
}
this.applyMenuClass(clearBtn, add);

Expand Down
3 changes: 2 additions & 1 deletion openbar@neuromorph/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
"46",
"47",
"48",
"49"
"49",
"50"
],
"url": "https://github.com/neuromorph/openbar",
"uuid": "openbar@neuromorph",
Expand Down