Fix uniform noise generation for events #322
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original UniformNoise implementation, x, y and polarity was randomly chosen using float values. For x and y it might not be a problem because of integer casting later, but for polarity it lead to a random choice of values center in 1, so most of polarity event generated will be casted in 1.
Fixing implementation : use np.random.randint for x, y and p instead of np.random.uniform.