ci(pypi): trigger publish on v* tag push, not only release event#87
Open
neuron7xLab wants to merge 1 commit into
Open
ci(pypi): trigger publish on v* tag push, not only release event#87neuron7xLab wants to merge 1 commit into
neuron7xLab wants to merge 1 commit into
Conversation
The publish workflow only ran on `release: published`. The GitHub releases for v0.3.0 and v0.4.0 were created by github-actions[bot] (the SLSA generator in release-artifact.yml uses GITHUB_TOKEN), and GitHub does not run workflows for events created by GITHUB_TOKEN — so publish-pypi never fired for those tags and nothing reached PyPI after the (separately failed) v0.2.0 run. Add a `push: tags: v*` trigger so a human tag push publishes directly, independent of who created the GitHub release. The OIDC trusted-publisher claim is unchanged (same workflow filename publish-pypi.yml, same `pypi` environment), and the pre-publish gate still asserts the tag matches the pyproject version. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gap
deployments/pypishows only one deployment (v0.2.0, which failed). v0.3.0 and v0.4.0 never published. Root causes:invalid-publisher(OIDC). (Fixed separately on pypi.org — one-time pending-publisher registration.)release: published, but the v0.3.0/v0.4.0 GitHub releases were created bygithub-actions[bot](SLSA generator, GITHUB_TOKEN). GitHub does not run workflows for events created by GITHUB_TOKEN, so publish never fired.Fix
Add
push: tags: v*so a human tag push publishes directly, independent of who created the release. OIDC claim unchanged (samepublish-pypi.yml, samepypienvironment); the pre-publish gate still asserts tag == pyproject version.Verified locally: YAML valid,
tools/check_github_actions_policy.pyPASS,python -m build+twine checkPASS for bsff 0.4.0 (wheel + sdist).🤖 Generated with Claude Code