Skip to content

fix(PG): salary filter input losing focus on debounce #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
viktor-yunenko merged 1 commit into from
Apr 30, 2026
Merged

fix(PG): salary filter input losing focus on debounce #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions client/src/sites/pg/components/PgFacetSalary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* #quality-25% #155 — see [[jobListFilters.ts]]
*/
import { Flex, NumberInput, Stack, Switch, Text } from "@chakra-ui/react";
import { useRef } from "react";
import { useEffect, useRef } from "react";
import { facetStyle } from "@/components/algolia/AlgoliaFacets";
import { ids } from "@/e2e/ids";
import { useJobListFilters } from "@/sites/pg/pages/jobs/list/jobListFilters";
Expand All @@ -12,6 +12,13 @@ const textStyle = { ...facetStyle.value, color: "fg" } as const;
export function PgFacetSalary() {
const filters = useJobListFilters();
const debounceRef = useRef<ReturnType<typeof setTimeout>>(null);
const inputRef = useRef<HTMLInputElement>(null);

useEffect(() => {
if (filters.snap.salaryMin == null && inputRef.current) {
inputRef.current.value = "";
}
}, [filters.snap.salaryMin]);

function handleValueChange(details: { valueAsNumber: number }) {
clearTimeout(debounceRef.current ?? undefined);
Expand All @@ -25,14 +32,14 @@ export function PgFacetSalary() {
return (
<Stack gap="gap.sm">
<NumberInput.Root
key={filters.snap.salaryMin ?? "empty"}
defaultValue={filters.snap.salaryMin != null ? String(filters.snap.salaryMin) : ""}
onValueChange={handleValueChange}
size="xs"
step={1000}
formatOptions={{ useGrouping: true }}
>
<NumberInput.Input
ref={inputRef}
placeholder="Minimum salary in USD (example: 50,000)"
{...ids.set(ids.facet.salaryInput)}
/>
Expand Down
Loading