Add WebSocket connection and message handling#171
Open
Nanotrejo wants to merge 8 commits intoneutralinojs:mainfrom
Open
Add WebSocket connection and message handling#171Nanotrejo wants to merge 8 commits intoneutralinojs:mainfrom
Nanotrejo wants to merge 8 commits intoneutralinojs:mainfrom
Conversation
Initializes WebSocket connection with dynamic protocol/port config. Adds functions to send and queue messages, and handle events. Implements error handling for token and connection issues.
Co-authored-by: Nanotrejo <43764924+Nanotrejo@users.noreply.github.com>
Updates the window zoom message to use 'zoom' as the parameter name for the zoom factor, aligning it with expected conventions.
Add native zoom API for window module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and improves the WebSocket connection logic in
src/ws/websocket.ts, with a focus on supporting both HTTP and HTTPS protocols, improving code readability, and applying consistent formatting and minor bug fixes. The most important changes are grouped below:WebSocket Protocol and Port Handling:
getWebSocketConfigfunction to dynamically determine the correct WebSocket protocol (wsorwss) and port based on the application's environment and how it is accessed (HTTP, HTTPS, or local development). Theinitfunction now uses this configuration to construct the WebSocket URL, enabling secure connections when needed.Bug Fixes and Minor Improvements:
extensionMessageQueue.