fix(updater): add SHA-256 checksum verification before binary installation#199
Open
bhumika-ks31 wants to merge 2 commits intoneutralinojs:mainfrom
Open
fix(updater): add SHA-256 checksum verification before binary installation#199bhumika-ks31 wants to merge 2 commits intoneutralinojs:mainfrom
bhumika-ks31 wants to merge 2 commits intoneutralinojs:mainfrom
Conversation
|
Hello @bhumika-ks31 ! ,
can you explain why are the hardcoded string being used in the code const a const b somewhat |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
## Summary
This PR fixes a security issue in the updater module where downloaded binaries were written to disk without integrity verification.
Previously,
install()downloaded the update binary and directly wrote it to disk without validating authenticity or integrity.Problem
Solution
checksum(SHA-256 hex) field to theManifesttypeinstall()now verifies the binary hash before writing to diskNE_UP_UPDCSERerror if checksum validation failscheckForUpdates()rejects manifests missing the checksum fieldSecurity Impact
Tests
npm run build -- --dev)