fix(frontendlib): use logical OR instead of bitwise OR for waitTimeout default#402
Open
salehahmed99 wants to merge 1 commit intoneutralinojs:mainfrom
Open
fix(frontendlib): use logical OR instead of bitwise OR for waitTimeout default#402salehahmed99 wants to merge 1 commit intoneutralinojs:mainfrom
salehahmed99 wants to merge 1 commit intoneutralinojs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces a bitwise OR operator (
|) with a logical OR operator (||) insrc/modules/frontendlib.js.The original use of the bitwise operator caused incorrect timeout calculations when a custom
waitTimeoutwas provided inneutralino.config.jsonbecause it performed bit-masking instead of a logical fallback. For example, a configured value of5000resulted in an actual timeout of24488ms (5000 | 20000).Fixes #401
Changes
timeoutvariable assignment to use||for proper fallback logic.