fix: prevent pluginloader.js from removing globally installed packages#404
Open
SARTHAK2427 wants to merge 1 commit intoneutralinojs:mainfrom
Open
fix: prevent pluginloader.js from removing globally installed packages#404SARTHAK2427 wants to merge 1 commit intoneutralinojs:mainfrom
SARTHAK2427 wants to merge 1 commit intoneutralinojs:mainfrom
Conversation
Author
|
@shalithasuranga please review this pr |
683053c to
7c4abe6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the CLI unintentionally removed globally installed npm packages during plugin removal
The current implementation uses
npm rm -g, which removes packages from the global environment instead of limiting the operation to the CLI or project scope. This leads to unintended system-wide deletions. During testing, a globally installed package was removed after running the plugin removal commandFixes #403
Changes
npm rm -g) with a safer alternative to prevent unintended removal of globally installed packages.neu: ERRR Unable to find pluginerror instead of a stack trace crash