fix: prevent sensitive data leakage from .storage during build#413
Open
SARTHAK2427 wants to merge 1 commit intoneutralinojs:mainfrom
Open
fix: prevent sensitive data leakage from .storage during build#413SARTHAK2427 wants to merge 1 commit intoneutralinojs:mainfrom
SARTHAK2427 wants to merge 1 commit intoneutralinojs:mainfrom
Conversation
Author
|
@shalithasuranga please review these security improvements let me know if you would like me to expand the blacklist or refine the user warnings |
713de9f to
2758ce8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevent Sensitive Data Leakage from
.storageduring BuildThis PR addresses a security vulnerability in the CLI bundler where sensitive development data (e.g., auth tokens, session state, environment variables) was accidentally leaked into production distributions when using the
--copy-storage flagFixes #412
Changes
bundler.jsImplemented aSENSITIVE_STORAGE_ITEMSblacklist that automatically filters high-risk files during the directory copy process for eg these filesAdded a user-facing warning that appears whenever the .storage directory is being packaged into a build, ensuring developers are aware of the potential for data inclusion.
The .storage directory is used by Neutralino apps at runtime to persist state. Developers often have their own testing credentials or environment secrets stored here locally. Packaging these into a production ZIP by default is a significant security risk that could lead to widespread credential leakage.
Manual Verification Output: