fix: warn when favicon.ico is missing in generated project#416
Open
Samridhi-2007 wants to merge 1 commit intoneutralinojs:mainfrom
Open
fix: warn when favicon.ico is missing in generated project#416Samridhi-2007 wants to merge 1 commit intoneutralinojs:mainfrom
Samridhi-2007 wants to merge 1 commit intoneutralinojs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #415
Problem
When creating a new Neutralinojs application using:
neu create
cd
neu run
the application logs a runtime error:
Unable to load application resource file /resources/favicon.ico
Root Cause
The default template (
neutralinojs/neutralinojs-minimal) does not include afavicon.icofile in theresources/directory. This results in runtime error logs, which can be confusing for new users.Solution
This PR introduces a proactive check during project creation:
resources/favicon.icois missingChanges Made
Added a file existence check for
resources/favicon.icoin:src/modules/creator.js
Displays the following warning if the file is missing:
Warning: favicon.ico not found in resources/. This file is optional but recommended.
Impact
Testing
neu createNote
A potential future improvement would be to include a default
favicon.icoin the template repository to eliminate this issue entirely.