Skip to content

fix: replace deprecated --load-dir-res with --res-mode=directory in runner.js#418

Open
salehahmed99 wants to merge 1 commit intoneutralinojs:mainfrom
salehahmed99:fix/deprecated-load-dir-res-flag
Open

fix: replace deprecated --load-dir-res with --res-mode=directory in runner.js#418
salehahmed99 wants to merge 1 commit intoneutralinojs:mainfrom
salehahmed99:fix/deprecated-load-dir-res-flag

Conversation

@salehahmed99
Copy link
Copy Markdown

Description

src/modules/runner.js was passing the --load-dir-res flag to the Neutralinojs binary when running neu run. This flag is marked as deprecated in the framework core (neutralinojs/settings.cpp) in favor of the newer --res-mode flag, which supports all three resource modes (directory, bundle, and embedded).

// neutralinojs/settings.cpp
// DEPRECATED: Resources read mode (resources.neu or from directory)
if(cliArg.key == "--load-dir-res") {
    resources::setMode(resources::ResourceModeDir);
    continue;
}

Changes

Replaced --load-dir-res with --res-mode=directory in src/modules/runner.js to use the current supported flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant