fix: replace bitwise OR with logical OR in waitTimeout handling (#401)#423
Open
Uday-Jav wants to merge 1 commit intoneutralinojs:mainfrom
Open
fix: replace bitwise OR with logical OR in waitTimeout handling (#401)#423Uday-Jav wants to merge 1 commit intoneutralinojs:mainfrom
Uday-Jav wants to merge 1 commit intoneutralinojs:mainfrom
Conversation
Uday-Jav
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #401
Description
This PR fixes an incorrect use of the bitwise OR (
|) operator in thewaitForFrontendLibAppfunction.The previous implementation used:
waitTimeout | 20000, which performs a bitwise operation and can lead to unexpected results.Fix
Replaced the bitwise OR (
|) with logical OR (||) to ensure proper fallback behavior whenwaitTimeoutis undefined.Impact