fix: handle offline/network errors in version command#433
Open
Swastik-Prakash1 wants to merge 1 commit intoneutralinojs:mainfrom
Open
fix: handle offline/network errors in version command#433Swastik-Prakash1 wants to merge 1 commit intoneutralinojs:mainfrom
Swastik-Prakash1 wants to merge 1 commit intoneutralinojs:mainfrom
Conversation
- Add 5s timeout to checkLatestVersion to prevent hang when npm registry is unreachable - Guard against null versionInfo to prevent TypeError crash - Fix double resolve() call in checkLatestVersion promise - Wrap getRemoteLatestVersion calls in version.js with try/catch to handle network failures gracefully - Show '(offline)' indicator when version check is unavailable Fixes: network error handling in neu version command Signed-off-by: Swastik Prakash <swastikprakashofficial@gmail.com>
Author
ProblemWhen the user is offline or the npm registry is unreachable, Additionally, the command hangs indefinitely waiting for npm to respond. A secondary issue: Changes
TestingTested by disconnecting network and running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: network error handling in neu version command