Repository navigation
Remove git config for dependabot user - #193
Merged
Merged
Conversation
Removed global git config commands for user name and email.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the git config commands that set the user name and email for the dependabot-sync bot in the Rush version sync workflow.
Key Changes:
- Removed
git config --global user.name "dependabot-sync[bot]"command - Removed
git config --global user.email "dependabot-sync[bot]@users.noreply.github.com"command
Comments suppressed due to low confidence (1)
.github/workflows/sync-rush-versions.yml:82
- The removal of git config commands will cause the git commit command on line 80 to fail. Git requires user.name and user.email to be configured before making commits. Without these config values, the workflow will error with "Please tell me who you are" when attempting to commit.
The actions/checkout action does not automatically configure git user identity. You need to either:
- Keep the git config commands (restore the removed lines)
- Use a GitHub Action that handles commits (e.g., stefanzweifel/git-auto-commit-action)
- Configure git user via the actions/checkout action if it supports that in v6
- name: Commit changes
run: |
# Add files that exist
if [ -f rush.json ]; then git add rush.json; fi
if [ -f common-versions.json ]; then git add common-versions.json; fi
if [ -f common/config/rush/npm-shrinkwrap.json ]; then git add common/config/rush/npm-shrinkwrap.json; fi
# Add all changes in common/scripts folder if it exists
if [ -d common/scripts ]; then git add common/scripts/; fi
if git diff --staged --quiet; then
echo "No changes to commit."
else
git commit -m "chore: sync rush.json and regenerate lockfiles"
git push
fi
Contributor
Author
|
@copilot revert this PR |
nev21
added a commit
that referenced
this pull request
Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed global git config commands for user name and email.