Repository navigation
Update conditions for auto-approve job - #211
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the conditions for the auto-approve job in the GitHub Actions workflow to use a more precise check for PR authors. The change moves from checking github.actor to github.event.pull_request.user.login, which is more specific to the PR creator rather than the workflow trigger actor.
Key changes:
- Replaced
github.actorwithgithub.event.pull_request.user.loginfor more accurate PR author identification - Removed the
dependabot-sync[bot]from the auto-approve list
| if: github.actor == 'dependabot[bot]' || github.actor == 'nev21' || github.actor == 'dependabot-sync[bot]' | ||
| if: | | ||
| github.event.pull_request.user.login == 'nev21' || | ||
| github.event.pull_request.user.login == 'dependabot[bot]' |
There was a problem hiding this comment.
The removal of 'dependabot-sync[bot]' from the auto-approve condition may be unintentional. If this bot should still be auto-approved, it needs to be added back to the condition list.
Suggested change
| github.event.pull_request.user.login == 'dependabot[bot]' | |
| github.event.pull_request.user.login == 'dependabot[bot]' || | |
| github.event.pull_request.user.login == 'dependabot-sync[bot]' |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.