Repository navigation
Downgrade @sinonjs/samsam dependency to resolve workflow parsing errors - #454
Merged
Merged
Conversation
Co-authored-by: nev21 <82737406+nev21@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Downgrade @sinonjs/samsam dependency due to workflow error
Downgrade @sinonjs/samsam dependency to resolve workflow parsing errors
Aug 22, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #454 +/- ##
=======================================
Coverage 98.89% 98.89%
=======================================
Files 108 108
Lines 2981 2981
Branches 645 622 -23
=======================================
Hits 2948 2948
Misses 33 33 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR downgrades the @sinonjs/samsam dependency from version 8.0.2 to 7.0.1 to resolve workflow parsing errors caused by incompatible modern JavaScript syntax in the newer version that karma-typescript cannot process.
- Downgrades @sinonjs/samsam from 8.0.2 to 7.0.1 in package.json overrides
- Aligns with the version range that sinon 15.0.0 naturally expects (^7.0.1)
- Resolves karma-typescript parsing errors that were blocking CI workflows
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
nev21
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent workflow failures were caused by karma-typescript being unable to parse newer JavaScript syntax in @sinonjs/samsam version 8.0.2. The error manifested as:
Root Cause
The package.json
overridessection was forcing @sinonjs/samsam to version 8.0.2, but sinon 15.0.0 naturally expects^7.0.1. Version 8.0.2 contains modern JavaScript syntax that is incompatible with the karma-typescript preprocessor used in the build pipeline.Solution
Updated the package.json override from:
to:
This aligns with the version that sinon 15.0.0 naturally expects and uses syntax compatible with the existing build tools.
Verification
The workflow should now complete successfully as the problematic parsing error has been resolved.
Fixes #453.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
googlechromelabs.github.ionode install.mjs(dns block)https://storage.googleapis.com/chrome-for-testing-public/139.0.7258.138/linux64/chrome-linux64.zipnode install.mjs(http block)www.googleapis.comnode install.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.