Skip to content

CI: switch Puppeteer loading to ESM import, pin Size tests to Node 22, and make Codecov upload non-blocking #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nev21 merged 3 commits into from
Jul 2, 2026
Merged

CI: switch Puppeteer loading to ESM import, pin Size tests to Node 22, and make Codecov upload non-blocking #582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f288f4
Initial plan
Copilot Jul 1, 2026
508d92a
Fix CI Puppeteer ESM loading and workflow stability
Copilot Jul 1, 2026
c0b7035
Pin @types/node to restore docs link check on Node 24
Copilot Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,13 @@ jobs:

- name: Upload Coverage
uses: codecov/codecov-action@v7
continue-on-error: true
with:
files: ./coverage/coverage-final.json
token: ${{ secrets.CODECOV_TOKEN }}

- name: Size tests
if: matrix.node == 24 || matrix.node == 22 || matrix.node == 20 || matrix.node == 18 # Only run size tests on the latest Node.js versions
if: matrix.node == 22
run: npm run size

- name: Bundle Size Checks
Expand Down
2 changes: 1 addition & 1 deletion karma.browser.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const childProcess = require('child_process');
function _resolvePuppeteerExecutablePathSync() {
return childProcess.execFileSync(process.execPath, [
"-e",
"require('puppeteer').executablePath().then((path) => process.stdout.write(path || ''))"
"import('puppeteer').then((m) => (m.default || m).executablePath()).then((path) => process.stdout.write(path || ''))"
], {
encoding: "utf8"
}).trim();
Expand Down
2 changes: 1 addition & 1 deletion karma.browser.esnext.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const childProcess = require('child_process');
function _resolvePuppeteerExecutablePathSync() {
return childProcess.execFileSync(process.execPath, [
"-e",
"require('puppeteer').executablePath().then((path) => process.stdout.write(path || ''))"
"import('puppeteer').then((m) => (m.default || m).executablePath()).then((path) => process.stdout.write(path || ''))"
], {
encoding: "utf8"
}).trim();
Expand Down
2 changes: 1 addition & 1 deletion karma.worker.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const childProcess = require('child_process');
function _resolvePuppeteerExecutablePathSync() {
return childProcess.execFileSync(process.execPath, [
"-e",
"require('puppeteer').executablePath().then((path) => process.stdout.write(path || ''))"
"import('puppeteer').then((m) => (m.default || m).executablePath()).then((path) => process.stdout.write(path || ''))"
], {
encoding: "utf8"
}).trim();
Expand Down
2 changes: 1 addition & 1 deletion karma.worker.esnext.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const childProcess = require('child_process');
function _resolvePuppeteerExecutablePathSync() {
return childProcess.execFileSync(process.execPath, [
"-e",
"require('puppeteer').executablePath().then((path) => process.stdout.write(path || ''))"
"import('puppeteer').then((m) => (m.default || m).executablePath()).then((path) => process.stdout.write(path || ''))"
], {
encoding: "utf8"
}).trim();
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@
"@types/eslint": "^8.56.10",
"@types/estree": "^1.0.0",
"@types/mocha": "^10.0.1",
"@types/node": "^20.19.43",
"@types/sinon": "^21.0.0",
"@typescript-eslint/eslint-plugin": "^7.14.1",
"@typescript-eslint/parser": "^7.14.1",
Expand Down