Create WindowsVCP for each physical monitor instead of logical#382
Merged
Conversation
Owner
|
Thanks for the PR! Feel free to ignore the failed coverage checks, -0.3% isn't anything to worry about. This might take a while for me to review, I want to check it on real hardware, and I'm away from my Windows computer on business travel. |
newAM
force-pushed
the
win-physical-monitors
branch
from
a6c0f5e to
f84ad38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #300. I have 4 monitors, but I don't have an environment that can reproduces the issue (i.e., multiple physical monitors for a logical monitor). The fix is verified only in my environment and in the unit tests.