Feature/rclone fork integration

.github/workflows/android.yml

@@ -1,60 +1,162 @@
-name: Android CI
+name: Android CI - APK Builds for Round-Sync
 
+# =============================================================================
+# Session Guardian Build Workflow
+# =============================================================================
+#
+# Simple, reliable workflow that builds APKs on Ubuntu runners
+# GitHub Actions provides 2000 free minutes/month for public repos.
+#
+# Session Guardian Features Built:
+# - TOTP time windows (T, T-1, T+1) for Internxt 2FA
+# - Exponential backoff (1m, 5m, 15m, 1h, 1h) with jitter
+# - Soft circuit breaker (max 5 retries, resets on success)
+# - 8-hour periodic health checks via WorkManager
+# - Manual re-auth option in remote menu
+# - Session expiry notifications
+#
+# =============================================================================
+
+# Triggers: Push commits, tags, or manual workflow_dispatch
 on:
-  workflow_dispatch:
   push:
+    branches: [master]
     tags:
       - '*'
+  workflow_dispatch:
+    inputs:
+      reason:
+        description: 'Reason for triggering build (e.g., "Test Session Guardian")'
+        required: false
+        default: 'Manual build'
 
 jobs:
   createArtifacts:
+    name: Build Android APKs
     runs-on: ubuntu-latest
+
     steps:
-    - uses: actions/checkout@v4
-    - name: Read Go version from project
-      run: echo "GO_VERSION=$(grep -E "^de\.felixnuesse\.extract\.goVersion=" gradle.properties | cut -d'=' -f2)"
-    - name: Set up JDK 17
-      uses: actions/setup-java@v3
-      with:
-        java-version: '17'
-        distribution: 'temurin'
-        cache: gradle
-    - name: Set up Go from gradle.properties
-      uses: actions/setup-go@v4
-      with:
-        go-version: '${{env.GO_VERSION}}'
-      id: go
-    - name: Setup Android SDK/NDK
-      uses: android-actions/setup-android@v3
-    - name: Install NDK from gradle.properties
-      run: |
-        NDK_VERSION="$(grep -E "^de\.felixnuesse\.extract\.ndkVersion=" gradle.properties | cut -d'=' -f2)"
-        sdkmanager "ndk;${NDK_VERSION}"
-    - name: Build app
-      run: ./gradlew assembleOssDebug
-    - name: Upload APK (arm)
-      uses: actions/upload-artifact@v4
-      with:
-        name: nightly-armeabi.apk
-        path: ${{ github.workspace }}/app/build/outputs/apk/oss/debug/*-oss-armeabi-v7a-debug.apk
-    - name: Upload APK (arm64)
-      uses: actions/upload-artifact@v4
-      with:
-        name: nightly-arm64.apk
-        path: ${{ github.workspace }}/app/build/outputs/apk/oss/debug/*-oss-arm64-v8a-debug.apk
-    - name: Upload APK (x86)
-      uses: actions/upload-artifact@v4
-      with:
-        name: nightly-x86.apk
-        path: ${{ github.workspace }}/app/build/outputs/apk/oss/debug/*-oss-x86-debug.apk
-    - name: Upload APK (arm)
-      uses: actions/upload-artifact@v4
-      with:
-        name: nightly-x64.apk
-        path: ${{ github.workspace }}/app/build/outputs/apk/oss/debug/*-oss-x86_64-debug.apk
-    - name: Upload APK (universal)
-      uses: actions/upload-artifact@v4
-      with:
-        name: nightly-universal.apk
-        path: ${{ github.workspace }}/app/build/outputs/apk/oss/debug/*-oss-universal-debug.apk
-        retention-days: 14
+      # Step 1: Checkout code
+      - name: Checkout Round-Sync code
+        uses: actions/checkout@v4
+
+      # Step 2: Read Go version from gradle.properties
+      - name: Read Go version
+        id: read-go-version
+        run: |
+          GO_VERSION=$(grep '^de\.felixnuesse\.extract\.goVersion=' gradle.properties | cut -d'=' -f2)
+          echo "GO_VERSION=$GO_VERSION" >> $GITHUB_ENV
+          echo "Go version to build: $GO_VERSION"
+
+      # Step 3: Install JDK 17
+      - name: Set up JDK 17
+        uses: actions/setup-java@v3
+        with:
+          java-version: '17'
+          distribution: 'temurin'
+          cache: gradle
+
+      # Step 4: Install Go
+      - name: Install Go
+        uses: actions/setup-go@v5
+        with:
+          go-version: '${{env.GO_VERSION}}'
+          cache: true
+
+      # Step 5: Install Android SDK and NDK
+      - name: Setup Android SDK/NDK
+        uses: android-actions/setup-android@v3
+
+      # Step 6: Install NDK (from gradle.properties)
+      - name: Install NDK
+        run: |
+          NDK_VERSION="$(grep '^de\.felixnuesse\.extract\.ndkVersion=' gradle.properties | cut -d'=' -f2)"
+          echo "Installing NDK version: $NDK_VERSION"
+          sdkmanager "ndk;${NDK_VERSION}"
+
+      # Step 7: Build Android app (OSS variant)
+      - name: Build app (OSS)
+        id: build-oss
+        run: |
+          echo "Building OSS Debug APK..."
+          ./gradlew assembleOssDebug
+          echo "Build completed!"
+
+      # Step 8: Upload ARM eabi-v7a APK
+      - name: Upload APK (arm32 - armeabi-v7a)
+        if: success()
+        uses: actions/upload-artifact@v4
+        with:
+          name: nightly-armeabi-v7a.apk
+          path: ${{ github.workspace }}/app/build/outputs/apk/oss/debug/*-oss-armeabi-v7a-debug.apk
+          if-no-files-found: warn
+          retention-days: 14
+
+      # Step 9: Upload ARM64-v8a APK (for Pixel 9)
+      - name: Upload APK (arm64 - for Pixel 9)
+        if: success()
+        uses: actions/upload-artifact@v4
+        with:
+          name: nightly-arm64-v8a.apk
+          path: ${{ github.workspace }}/app/build/outputs/apk/oss/debug/*-oss-arm64-v8a-debug.apk
+          if-no-files-found: warn
+          retention-days: 14
+
+      # Step 10: Upload x86 APK
+      - name: Upload APK (x86)
+        if: success()
+        uses: actions/upload-artifact@v4
+        with:
+          name: nightly-x86.apk
+          path: ${{ github.workspace }}/app/build/outputs/apk/oss/debug/*-oss-x86-debug.apk
+          if-no-files-found: warn
+          retention-days: 14
+
+      # Step 11: Upload x86_64 APK
+      - name: Upload APK (x86_64)
+        if: success()
+        uses: actions/upload-artifact@v4
+        with:
+          name: nightly-x86_64.apk
+          path: ${{ github.workspace }}/app/build/outputs/apk/oss/debug/*-oss-x86_64-debug.apk
+          if-no-files-found: warn
+          retention-days: 14
+
+      # Step 12: Upload universal APK
+      - name: Upload APK (universal)
+        if: success()
+        uses: actions/upload-artifact@v4
+        with:
+          name: nightly-universal.apk
+          path: ${{ github.workspace }}/app/build/outputs/apk/oss/debug/*-oss-universal-debug.apk
+          if-no-files-found: warn
+          retention-days: 14
+
+      # Step 13: Build summary
+      - name: Build summary
+        if: always()
+        run: |
+          echo "## Build Summary"
+          echo ""
+          echo "**APKs Generated:**"
+          echo "- arm64-v8a (for Pixel 9)"
+          echo "- armeabi-v7a"
+          echo "- x86"
+          echo "- x86_64"
+          echo "- universal"
+          echo ""
+          echo "**Session Guardian Features:**"
+          echo "- TOTP time windows (T, T-1, T+1) for 2FA clock skew"
+          echo "- Exponential backoff (1m → 5m → 15m → 1h → 1h)"
+          echo "- Soft circuit breaker (max 5 retries)"
+          echo "- 8-hour health checks via WorkManager"
+          echo "- Manual re-auth UI option"
+          echo "- Session expiry notifications"
+          echo ""
+          echo "**Download:**"
+          echo "After 5-10 minutes, download artifacts from:"
+          echo "https://github.com/thies2005/Round-Sync/actions"
+          echo ""
+          echo "**For Pixel 9 (arm64-v8a):**"
+          echo "Download: nightly-arm64-v8a.apk"
+          echo "Install and test Session Guardian features!"

.github/workflows/dependencies.yml

@@ -33,15 +33,18 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Read Go version from project
-        run: echo "GO_VERSION=$(grep -E "^de\.felixnuesse\.extract\.goVersion=" gradle.properties | cut -d'=' -f2)"
+        run: |
+          GO_VERSION=$(grep -E "^de\.felixnuesse\.extract\.goVersion=" gradle.properties | cut -d'=' -f2)
+          echo "GO_VERSION=$GO_VERSION" >> $GITHUB_ENV
+          echo "Go version: $GO_VERSION"
       - name: Set up JDK 17
         uses: actions/setup-java@v3
         with:
           java-version: '17'
           distribution: 'temurin'
           cache: gradle
       - name: Set up Go from gradle.properties
-        uses: actions/setup-go@v4
+        uses: actions/setup-go@v5
         with:
           go-version: '${{env.GO_VERSION}}'
         id: go

.vscode/settings.json

@@ -0,0 +1,3 @@
+{
+    "java.configuration.updateBuildConfiguration": "interactive"
+}

AGENTS.md

@@ -0,0 +1,96 @@
+# CloudBridge — Agent Notes
+
+Android cloud file manager wrapping [rclone](https://rclone.org). Fork of RCX / rcloneExplorer.
+
+## Build
+
+**Prerequisites**: Go 1.25+, JDK 17, Android SDK with NDK. Versions are pinned in `gradle.properties` — check there first if builds break.
+
+```sh
+# Debug (CI uses this)
+./gradlew assembleOssDebug
+
+# Release
+./gradlew assembleOssRelease
+```
+
+- Two product flavors: **`oss`** and **`rs`** (dimension: `edition`). Almost all work targets `oss`.
+- APK output: `app/build/outputs/apk/oss/debug/`
+- ABI splits: armeabi-v7a, arm64-v8a, x86, x86_64, universal
+
+## Module structure
+
+| Module | Purpose |
+|---|---|
+| `app` | Main Android application |
+| `rclone` | Cross-compiles rclone (Go) into `librclone.so` per ABI |
+| `safdav` | SAF/WebDAV bridge library (`io.github.x0b.safdav`) |
+
+`app:preBuild` depends on `:rclone:buildAll`, so the app build automatically triggers rclone cross-compilation. First build downloads and caches rclone source in `rclone/cache/`.
+
+## rclone source
+
+The rclone binary is built from the fork at `https://github.com/thies2005/rclone` (which includes Internxt auto-token-renewal). Source is controlled by two properties in `gradle.properties`:
+
+| Property | What it controls |
+|---|---|
+| `rCloneRepoUrl` | Git remote URL to clone from |
+| `rCloneRef` | Branch, tag, or commit to checkout and build |
+
+**To upgrade the fork**: change `rCloneRef` (e.g. to a newer tag or commit), then rebuild. The build script will `git fetch` + `git checkout` on every build, so no manual cache clearing is needed.
+
+The old `rclone/patches/` directory is no longer used — the fork contains the Internxt backend changes directly.
+
+## Lint
+
+```sh
+./gradlew lint -x :rclone:buildAll
+```
+
+Lint skips rclone compilation to save time. Lint baselines exist (`lint-baseline.xml` in `app/` and `safdav/`). `abortOnError` is enabled; `MissingTranslation` is demoted to warning.
+
+## Testing
+
+Minimal test coverage — only two unit tests in `app/src/test/`. Run with:
+
+```sh
+./gradlew testOssDebugUnitTest
+```
+
+No instrumented/androidTest runner is wired in CI.
+
+## Architecture / source layout
+
+- **Package namespace**: `ca.pkay.rcloneexplorer` (legacy from rcloneExplorer fork)
+- **Application ID**: `de.schuelken.cloudbridge`
+- Newer code lives under `de.schuelken.cloudbridge.*`
+- `app/src/rcx/` — additional source set (RCX-specific utilities)
+- `rclone/patches/` — **DEPRECATED**, no longer used. Fork already contains Internxt backend.
+- The rclone binary is statically compiled with `CGO_ENABLED=0` and shipped as `librclone.so` per ABI in `app/lib/`.
+
+## Key version pins (`gradle.properties`)
+
+| Property | What it controls |
+|---|---|
+| `de.schuelken.cloudbridge.goVersion` | Go toolchain version (informational) |
+| `de.schuelken.cloudbridge.rCloneVersion` | Fallback rclone version (if VERSION file unreadable) |
+| `de.schuelken.cloudbridge.rCloneRepoUrl` | Git URL for the rclone fork |
+| `de.schuelken.cloudbridge.rCloneRef` | Git ref (branch/tag/commit) to build from |
+| `de.schuelken.cloudbridge.ndkVersion` | Android NDK version for cross-compilation |
+| `de.schuelken.cloudbridge.ndkToolchainVersion` | NDK toolchain API level |
+
+## CI workflows
+
+- **`android.yml`**: Builds debug APKs on push to master; uploads per-ABI artifacts.
+- **`lint.yml`**: Runs lint on every PR (not on master).
+- **`dependencies.yml`**: Rebuilds on `build.gradle` changes and runs FOSS library scan.
+- **`translations.yml`**: Profanity-checks translated `strings.xml` on PRs.
+
+## Gotchas
+
+- **Windows builds**: The rclone module handles Windows-specific NDK paths (`.cmd` suffixes, CRLF→LF conversion on patched Go files).
+- **Debug applicationId**: Debug builds append `.debug` to the application ID, so debug and release can coexist on a device.
+- **`versionCode`**: Last digit is reserved for ABI multiplier — version codes end in `0`.
+- **Version Updates**: Always update the small versions (patch version and `versionCode`) with each build.
+- **`local.properties`** with `sdk.dir` or `ANDROID_HOME` env var is required for rclone cross-compilation.
+- Translations are managed via Weblate and Crowdin — don't manually edit localized `strings.xml` unless adding a new language.