Add GitHub Actions CI workflow #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add CI workflow that runs tests, lint, and build on PRs - Consolidate .mise.toml into mise.toml - Switch lefthook and yq to aqua registry Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Skip TestKillProcess_ActualProcess when CI env var is set - Refactor test to use testify/require - Add test timeout to CI workflow Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Run linter on ./... instead of individual staged files to properly resolve package symbols. The --new-from-rev flag already filters to only report issues in changed code. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add ProcessLister and ProcessKiller interfaces for dependency injection - Create mock implementations for safe, reliable unit tests - Remove tests that called real system commands (ps, pkill) - Add empty pattern validation to prevent killing all processes - Tests no longer depend on system state or spawn real processes The previous tests were dangerous - calling KillProcess with an empty pattern would match all processes and kill the CI runner itself. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.mise.tomlintomise.toml(single config file)Test plan
🤖 Generated with Claude Code