Conversation
There was a problem hiding this comment.
Pull request overview
This pull request primarily bumps ContainDB’s release version from 7.17.42-stable to 7.18.42-stable across the CLI, packaging metadata, and install documentation/scripts, and also introduces a new system design document.
Changes:
- Updated hardcoded version strings in Go sources, installer script, and root
VERSION. - Updated npm package version to
7.18.42. - Updated installation docs and added a large
DESIGN.mddocument.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/base/Banner.go | Updates banner version constant to 7.18.42-stable. |
| src/Core/main.go | Updates CLI --version output version string to 7.18.42-stable. |
| npm/package.json | Updates npm package version to 7.18.42. |
| VERSION | Updates canonical version file to 7.18.42-stable. |
| Scripts/installer.sh | Updates installer download/version to 7.18.42-stable. |
| INSTALLATION.md | Updates example .deb download/install commands to the new version. |
| DESIGN.md | Adds a comprehensive system design document (currently includes older version references). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,3237 @@ | |||
| # ContainDB System Design Document | |||
|
|
|||
| **Version:** 7.17.42-stable | |||
There was a problem hiding this comment.
This document header still states version 7.17.42-stable, but the PR updates the project version to 7.18.42-stable elsewhere for consistency. Update the design doc's version metadata (and any version-specific references that are intended to reflect the current release) to avoid conflicting source-of-truth in docs.
| **Version:** 7.17.42-stable | |
| **Version:** 7.18.42-stable |
| func main() { | ||
| VERSION := "7.17.42-stable" | ||
|
|
There was a problem hiding this comment.
This example code block still shows VERSION := "7.17.42-stable", which conflicts with the updated version in src/Core/main.go and the PR’s stated goal of keeping versions consistent. Update the snippet to match the current version (or refactor the doc to avoid embedding hardcoded version strings).
|
|
||
| The SIGINT handler (lines 50-57) ensures graceful cleanup on Ctrl+C interrupts. This is critical for preventing orphaned containers or partial deployments. | ||
|
|
||
| **Reference:** `/home/ankan/Documents/Projects/ContainDB/src/Core/main.go:50-57` |
There was a problem hiding this comment.
The design doc includes absolute local filesystem paths (e.g. /home/ankan/Documents/Projects/ContainDB/...). These aren’t meaningful to other contributors and can unintentionally leak local environment details; prefer repo-relative references like src/Core/main.go:50-57.
| **Reference:** `/home/ankan/Documents/Projects/ContainDB/src/Core/main.go:50-57` | |
| **Reference:** `src/Core/main.go:50-57` |
| # ContainDB System Design Document | ||
|
|
||
| **Version:** 7.17.42-stable | ||
| **Last Updated:** 2026-03-01 | ||
| **Document Purpose:** Technical architecture and design documentation for developers and contributors |
There was a problem hiding this comment.
The PR description focuses on a version bump across existing files, but this PR also adds a new ~3k-line DESIGN.md document. Please update the PR description to explicitly include this addition (or split it into a separate PR) so reviewers can properly scope and review the change.
| func main() { | ||
| VERSION := "7.17.42-stable" | ||
| VERSION := "7.18.42-stable" | ||
|
|
There was a problem hiding this comment.
The version is hardcoded here while src/base/Banner.go and the root VERSION file also define the version separately. To prevent future drift (especially in a PR intended to ensure version consistency), consider using a single source of truth (e.g., reuse base.Version, or inject the version at build time via -ldflags, or read from the VERSION file).
| # Download the latest .deb release | ||
| wget https://github.com/nexoral/ContainDB/releases/download/v7.17.42-stable/containDB_7.17.42-stable_amd64.deb | ||
| wget https://github.com/nexoral/ContainDB/releases/download/v7.18.42-stable/containDB_7.18.42-stable_amd64.deb | ||
|
|
||
| # Install the package | ||
| sudo dpkg -i containDB_7.17.42-stable_amd64.deb | ||
| sudo dpkg -i containDB_7.18.42-stable_amd64.deb |
There was a problem hiding this comment.
The .deb filename and URL here use containDB_... (camel-case), but the release/installer tooling in this repo uses containdb_${VERSION}_<arch>.deb (lowercase) (see Scripts/installer.sh and Scripts/PackageBuilder.sh). As written, these copy/paste commands are likely to 404 or fail on case-sensitive filesystems; align the docs with the actual release asset naming (or adjust the build/release scripts to match the docs).
This pull request updates the project version from
7.17.42-stableto7.18.42-stableacross multiple files to ensure consistency throughout the codebase and installation scripts.Version update across the codebase:
7.18.42-stablein the main Go application (src/Core/main.go) and the banner display (src/base/Banner.go). [1] [2]VERSIONfile andnpm/package.jsonto7.18.42-stableand7.18.42respectively. [1] [2]Installer and documentation updates:
INSTALLATION.mdand the installer scriptScripts/installer.shto reference the new version and download URLs. [1] [2]