feat: add bloated devcontainer and remove project governance templates#52
feat: add bloated devcontainer and remove project governance templates#52
Conversation
…js environment setup chore: Remove outdated issue and pull request templates chore: Update version to v5.21
github-actions
bot
changed the title
🤖 Review Buddy - General Code Review
Oye @AnkanSaha! Ye kya bawasir bana diye ho? PR title 'feat' likh ke chhodd diya, jaise hum antaryami hain ki samajh jayenge tumne kya kaand kiya hai. Devcontainer ke naam pe poora OS bhar diya hai aur Github templates aise delete kiye hain jaise ex ki photos. Code Quality Score: 3/10. Bhai, thoda toh sharam karo, 'npm install --force' use kar rahe ho? Isse accha toh manual copy-paste hi kar lete. Aur ye GPU true kyun hai? Node.js mein kaunsa Ray Tracing kar rahe ho tum? Sudhar jao, varna agli baar terminal se bahar nikal ke maarunga. Generated by Review Buddy | Tone: roast | Language: hinglish |
⚡ Review Buddy - Performance Analysis
Arre bhai bhai bhai! Performance ke naam pe tumne toh maut ka nanga naach shuru kar diya hai.
Recommendation: Use multi-stage builds, remove unnecessary global CLIs, and for the love of God, stop using --force. Generated by Review Buddy | Tone: roast | Language: hinglish |
🔐 Review Buddy - Security Audit
Security ka toh tumne mazaak bana diya hai.
Remediation: Root user hatao, non-root user (node) use karo. Script piping band karo. OWASP Top 10 padho thoda. Generated by Review Buddy | Tone: roast | Language: hinglish |
📊 Review Buddy - Code Quality & Maintainability Analysis
🎯 Overall Benchmark: 25/100 (Poor)Quality? Kaunsi quality? Yahan toh sirf chaos hai.
Refactoring suggestion: Use a loop for directory traversal and installation. Restore the deleted templates. Fix the user permissions. Generated by Review Buddy | Tone: roast | Language: hinglish |
💡 Review Buddy - Best Practices & Alternative Suggestions
Bhai, ye dekh aur seekh: Current Bawasir: cd ./Document && npm i --force && cd ..
cd ./GUI && npm i --force && cd ..Better Alternative: # Use a loop and avoid --force if possible
for dir in . ./Document ./GUI; do
if [ -d "$dir" ]; then
echo "Installing dependencies in $dir..."
(cd "$dir" && npm install)
fi
doneWhy: Readability badhti hai aur code DRY rehta hai. Current Risk: "remoteUser": "root"Better Alternative: "remoteUser": "node"Why: Least privilege principle, beta. Security 101. Template Deletion: Generated by Review Buddy | Tone: roast | Language: hinglish |
🚫 Review Buddy - Final Recommendation
Recommendation: REJECTArre bhai bhai bhai! Ye PR toh reject karna padega! Reasoning:
📋 Review Checklist for Reviewers:
🎯 Next Steps:🚫 Critical issues hai - is PR ko reject karo aur major fixes ke baad dobara submit karo.Generated by Review Buddy | Tone: roast | Language: hinglish |
There was a problem hiding this comment.
Pull request overview
This PR updates the repository version and introduces a VS Code Dev Container setup, while also removing GitHub PR/issue templates.
Changes:
- Bump
VERSIONfromv5.19tov5.21. - Remove
.github/pull_request_template.mdand the issue templates for bugs/features. - Add a
.devcontainer/configuration and a post-create provisioning script.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
VERSION |
Version bump to v5.21. |
.github/pull_request_template.md |
Removes the PR template. |
.github/ISSUE_TEMPLATE/feature_request.md |
Removes the feature request template. |
.github/ISSUE_TEMPLATE/bug_report.md |
Removes the bug report template. |
.devcontainer/devcontainer.json |
Adds a Dev Container configuration (currently missing a container definition). |
.devcontainer/postCreateCommand.sh |
Adds provisioning steps for the devcontainer (currently references non-existent paths and has reproducibility/safety concerns). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "name": "Node.js & TypeScript", | ||
| "hostRequirements": { | ||
| "cpus": 2, // 2 CPUs are required for the universal image | ||
| "gpu": true, // GPU is required for the universal image |
| "forwardPorts": [ | ||
| 27018 | ||
| ], | ||
| "postCreateCommand": "./.devcontainer/postCreateCommand.sh", |
| # Install Dependencies for the AxioDB Documentation | ||
| cd ./Document && npm i --force && cd .. # Install & build dependencies for AxioDB Documentation | ||
|
|
||
| # Install Dependencies for the AxioDB GUI | ||
| cd ./GUI && npm i --force && cd .. # Install & build dependencies for AxioDB GUI |
| sudo apt-get update -y # Update apt-get cache | ||
| sudo apt-get install -y neofetch # Install curl | ||
|
|
||
| # install Node.js and npm | ||
| curl -sL https://deb.nodesource.com/setup_22.x | sudo -E bash | ||
| sudo apt-get install -y nodejs # Install Node.js and npm |
| #!/bin/bash | ||
|
|
||
| sudo apt-get update -y # Update apt-get cache | ||
| sudo apt-get install -y neofetch # Install curl | ||
|
|
||
| # install Node.js and npm | ||
| curl -sL https://deb.nodesource.com/setup_22.x | sudo -E bash | ||
| sudo apt-get install -y nodejs # Install Node.js and npm | ||
|
|
||
| # Install Dependencies for all the section of this project | ||
| npm install --force && npm run build # Install & build dependencies for AxioDB main Codebase | ||
|
|
| npm install --force && npm run build # Install & build dependencies for AxioDB main Codebase | ||
|
|
||
| # Install Dependencies for the AxioDB Documentation | ||
| cd ./Document && npm i --force && cd .. # Install & build dependencies for AxioDB Documentation | ||
|
|
||
| # Install Dependencies for the AxioDB GUI | ||
| cd ./GUI && npm i --force && cd .. # Install & build dependencies for AxioDB GUI |
| # install Node.js and npm | ||
| curl -sL https://deb.nodesource.com/setup_22.x | sudo -E bash | ||
| sudo apt-get install -y nodejs # Install Node.js and npm | ||
|
|
||
| # Install Dependencies for all the section of this project | ||
| npm install --force && npm run build # Install & build dependencies for AxioDB main Codebase |
| "memory": "4gb" // 4gb is the minimum requirement for the universal image | ||
| }, | ||
| // // Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile | ||
| // "image": "mcr.microsoft.com/devcontainers/typescript-node:1-20-bullseye", |
Summary
This PR introduces a heavy-duty DevContainer configuration and inexplicably deletes all GitHub issue and pull request templates. It also bumps the version from v5.19 to v5.21.
Changes
.devcontainer/devcontainer.jsonwith extreme resource requirements (GPU, 20GB disk).postCreateCommand.shthat installs multiple AI CLIs and usesnpm install --forceacross sub-directories..github/ISSUE_TEMPLATE/bug_report.md,feature_request.md, andpull_request_template.md.VERSIONto v5.21.Verification