Skip to content

fix: Replace deprecated url.parse() with WHATWG URL API#955

Merged
stevenjoezhang merged 2 commits into
next-theme:masterfrom
pilgrimlyieu:master
May 6, 2026
Merged

fix: Replace deprecated url.parse() with WHATWG URL API#955
stevenjoezhang merged 2 commits into
next-theme:masterfrom
pilgrimlyieu:master

Conversation

@pilgrimlyieu
Copy link
Copy Markdown
Contributor

PR Checklist

  • The changes have been tested (for bug fixes / features).
  • Docs in NexT website have been added / updated (for features).

PR Type

  • Bugfix.
  • Feature.
  • Improvement.
  • Code style update (e.g. formatting, linting).
  • Refactoring (no changes to functionality and APIs).
  • Documentation.
  • Translation.
  • Other... Please describe:

What is the current behavior?

Node deprecation warning when hexo s:

(node:7632) [DEP0169] DeprecationWarning: `url.parse()` behavior is not standardized and prone to errors that have security implications. Use the WHATWG URL API instead. CVEs are not issued for `url.parse()` vulnerabilities.
(Use `node --trace-deprecation ...` to show where the warning was created)

Issue resolved:

What is the new behavior?

No deprecation warning.

  • Link to demo site with this changes:
  • Screenshots with this changes:

How to use?

In NexT _config.yml:

Irrelevant.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 21, 2026

CLA assistant check
All committers have signed the CLA.

Comment thread scripts/helpers/next-config.js Fixed
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 24755500727

Coverage remained the same at 97.451%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 405
Covered Lines: 400
Line Coverage: 98.77%
Relevant Branches: 105
Covered Branches: 97
Branch Coverage: 92.38%
Branches in Coverage %: Yes
Coverage Strength: 3.63 hits per line

💛 - Coveralls

@stevenjoezhang stevenjoezhang added this to the 8.28.0 milestone May 6, 2026
@stevenjoezhang stevenjoezhang merged commit 8aa84d7 into next-theme:master May 6, 2026
10 checks passed
@welcome
Copy link
Copy Markdown

welcome Bot commented May 6, 2026

Congrats on merging your first pull request here! 🎉 How awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants