test(playground): mark protected fixtures the way nodes are - #69
Merged
Merged
Conversation
The playground marked its protected fixture with hideDownload, which the viewer stopped reading in #65, so the restrictions e2e failed. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
added
status: review
skjnldsv
added
status: review
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
=======================================
Coverage 88.90% 88.90%
=======================================
Files 39 39
Lines 2776 2776
Branches 575 575
=======================================
Hits 2468 2468
Misses 301 301
Partials 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The playground marked its protected fixture with
hideDownload, the name #65 stopped reading, soe2e/restrictions.spec.tshas failed since #65 went in, and it blocks #68. It uses the dav namehide-downloadnow, like the nodes #65 reads.I missed this on #65: only its unit tests ran locally, and I did not check its CI before it was merged.
Passes locally on Chromium with the fix and fails without it. Firefox is left to CI.
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.