fix: update role of NcHeaderMenu - #8874
Closed
kristian-zendato wants to merge 1 commit into
Closed
kristian-zendato wants to merge 1 commit into
kristian-zendato wants to merge 1 commit into
Conversation
7 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8874 +/- ##
==========================================
- Coverage 52.23% 51.98% -0.25%
==========================================
Files 115 120 +5
Lines 4009 4338 +329
Branches 1181 1289 +108
==========================================
+ Hits 2094 2255 +161
- Misses 1635 1766 +131
- Partials 280 317 +37 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ShGKme
requested changes
Aug 24, 2026
Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
kristian-zendato
force-pushed
the
fix/headermenu-role
branch
from
August 26, 2026 07:36
9de2a1f to
7c65224
Compare
ShGKme
requested changes
Aug 26, 2026
ShGKme
left a comment
Contributor
There was a problem hiding this comment.
- With
role="menuitem"here,isNavis still not valid. If we deprecatedisNavprop as @susnux proposed, all theisNavhandling must be removed. Otherwise we have an invalid state, wheremenuitemare items of the navigation instead if the menu. - This PR is compatible with the linked server PR for Nextcloud 35. However, it breaks all the previous versions semantics, where the header is not a manubar. We need to either add a new prop here, or check the server version, assuming, this is server version defined.
See also: nextcloud/server#63239 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Summary
Update role of
NcHeaderMenutomenuitem🚧 Tasks
🏁 Checklist
stable8for maintained Vue 2 version or not applicable