Skip to content

fix: update role of NcHeaderMenu - #8874

Closed
kristian-zendato wants to merge 1 commit into
mainfrom
fix/headermenu-role
Closed

kristian-zendato wants to merge 1 commit into
mainfrom
fix/headermenu-role

Conversation

@kristian-zendato

@kristian-zendato kristian-zendato commented Aug 24, 2026 •

Copy link
Copy Markdown
Contributor

☑️ Resolves

Summary

Update role of NcHeaderMenu to menuitem

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@kristian-zendato kristian-zendato added 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Aug 24, 2026
@codecov

codecov Bot commented Aug 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.98%. Comparing base (0e0af10) to head (7c65224).
⚠️ Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8874      +/-   ##
==========================================
- Coverage   52.23%   51.98%   -0.25%     
==========================================
  Files         115      120       +5     
  Lines        4009     4338     +329     
  Branches     1181     1289     +108     
==========================================
+ Hits         2094     2255     +161     
- Misses       1635     1766     +131     
- Partials      280      317      +37     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/components/NcHeaderMenu/NcHeaderMenu.vue Outdated
Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
@ShGKme ShGKme added the bug Something isn't working label Aug 26, 2026

@ShGKme ShGKme left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. With role="menuitem" here, isNav is still not valid. If we deprecated isNav prop as @susnux proposed, all the isNav handling must be removed. Otherwise we have an invalid state, where menuitem are items of the navigation instead if the menu.
  2. This PR is compatible with the linked server PR for Nextcloud 35. However, it breaks all the previous versions semantics, where the header is not a manubar. We need to either add a new prop here, or check the server version, assuming, this is server version defined.

See also: nextcloud/server#63239 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants