Skip to content

AIO-interface: validate Sec-Fetch-* headers #8786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szaimen merged 3 commits into from
Oct 14, 2026
Merged

AIO-interface: validate Sec-Fetch-* headers #8786

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1671ea
validate Sec-Fetch-* headers
Zoey2936 Oct 3, 2026
ae4291b
apply suggestion
Zoey2936 Oct 8, 2026
2abc5bd
Apply suggestion from @szaimen
szaimen Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions php/public/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,31 @@
// Auth Middleware
$app->add(new \AIO\Middleware\AuthMiddleware($container->get(\AIO\Auth\AuthManager::class)));

// Check Sec-Fetch headers
$app->add(function (Request $request, \Psr\Http\Server\RequestHandlerInterface $handler) use ($responseFactory) : Response {
Comment thread
szaimen marked this conversation as resolved.
// allow same-origin and none
if (in_array($request->getHeaderLine('Sec-Fetch-Site'), ['same-origin', 'none'], true)) {
return $handler->handle($request);
}

$isDocumentNavigation = $request->getMethod() === 'GET' && $request->getHeaderLine('Sec-Fetch-Mode') === 'navigate' && $request->getHeaderLine('Sec-Fetch-Dest') === 'document';

// allow cross-origin navigations to /api/auth/getlogin (with any query params)
if ($isDocumentNavigation && $request->getUri()->getPath() === '/api/auth/getlogin') {
return $handler->handle($request);
}

// allow cross-origin navigations to `/`, and `/login`, if no query params are set
if ($isDocumentNavigation && in_array($request->getUri()->getPath(), ['/', '/login'], true) && $request->getUri()->getQuery() === '') {
return $handler->handle($request);
}

// else deny
$response = $responseFactory->createResponse(403);
$response->getBody()->write('Forbidden');
return $response;
});

// API
$app->post('/api/docker/watchtower', AIO\Controller\DockerController::class . ':StartWatchtowerContainer');
$app->get('/api/docker/getwatchtower', AIO\Controller\DockerController::class . ':StartWatchtowerContainer');
Expand Down
Loading