Skip to content

build(Nextcloud): pin php smbclient to 1.1.2 and add it to dependency updates - #8805

Merged
szaimen merged 2 commits into
mainfrom
build/pin-smbclient
Oct 14, 2026
Merged

szaimen merged 2 commits into
mainfrom
build/pin-smbclient

Conversation

@szaimen

@szaimen szaimen commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

PECL lists 1.2.0dev as stable, so an unpinned install pulled the dev build. Pin the latest stable release and let the dependency-updates workflow bump it, skipping dev tags.

Summary

  • The PR was tested and verified that it works locally
  • Or will be tested after merge on a dedicated test instance (available for maintainers)
  • Sign-off message is added to all commits
  • Tests (playwright if possible) are included
  • Screenshots before/after for front-end changes
  • Documentation has been updated or is not required
  • Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
  • Milestone next added

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@szaimen szaimen changed the title build(Nextcloud): pin php smbclient to 1.1.2 and add it to dependency… build(Nextcloud): pin php smbclient to 1.1.2 and add it to dependency updates Oct 8, 2026
@szaimen szaimen added 3. to review Waiting for reviews enhancement New feature or request labels Oct 8, 2026
@szaimen szaimen added this to the next milestone Oct 8, 2026
@szaimen
szaimen marked this pull request as ready for review October 8, 2026 08:05
@szaimen
szaimen requested a review from pabzm October 8, 2026 08:05
@szaimen szaimen modified the milestones: v14.3.0, next Oct 8, 2026

@pabzm pabzm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted! Getting the release version can be done easier, though.

Comment thread .github/workflows/dependency-updates.yml Outdated
@szaimen
szaimen requested a review from pabzm October 14, 2026 10:30
szaimen and others added 2 commits October 14, 2026 13:46
… updates

PECL lists 1.2.0dev as stable, so an unpinned install pulled the dev
build. Pin the latest stable release and let the dependency-updates
workflow bump it, skipping dev tags.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Simon L. <szaimen@e.mail.de>
Co-authored-by: Pablo Zmdl <57864086+pabzm@users.noreply.github.com>
Signed-off-by: Simon L. <szaimen@e.mail.de>
@szaimen
szaimen force-pushed the build/pin-smbclient branch from b81ae24 to 9cf1b85 Compare October 14, 2026 11:46
@szaimen
szaimen merged commit f113cb8 into main Oct 14, 2026
6 checks passed
@szaimen
szaimen deleted the build/pin-smbclient branch October 14, 2026 13:46
@szaimen

szaimen commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator Author

This is now released with v14.4.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants