Skip to content

fix(imaginary): always log on info level - #8811

Open
szaimen wants to merge 2 commits into
mainfrom
fix/imaginary-info-logs
Open

szaimen wants to merge 2 commits into
mainfrom
fix/imaginary-info-logs

Conversation

@szaimen

@szaimen szaimen commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

Imaginary now always logs on info level so that it is visible what it does. Debug output is still additionally enabled if AIO_LOG_LEVEL is set to debug.

Summary

  • The PR was tested and verified that it works locally
  • Or will be tested after merge on a dedicated test instance (available for maintainers)
  • Sign-off message is added to all commits
  • Tests (playwright if possible) are included
  • Screenshots before/after for front-end changes
  • Documentation has been updated or is not required
  • Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
  • Milestone next added

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Imaginary now always logs on info level so that it is visible what it
does. Debug output is still additionally enabled if AIO_LOG_LEVEL is set
to debug.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Simon L. <szaimen@e.mail.de>
@szaimen szaimen added this to the next milestone Oct 8, 2026
@szaimen szaimen added 3. to review Waiting for reviews enhancement New feature or request labels Oct 8, 2026
@szaimen
szaimen requested a review from pabzm October 8, 2026 09:33

@pabzm pabzm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change there's no way anymore for users to make imaginary be quieter, right?

Is that on purpose?

I'd prefer to keep AIO_LOG_LEVEL determining all application's log levels, and not to introduce exceptions, because they increase complexity.

At least unless there's a grave reason for the change. Just for seeing what the apps do, users could set well set AIO_LOG_LEVEL to info, or not?

@szaimen
szaimen requested a review from pabzm October 13, 2026 09:30
@pabzm

pabzm commented Oct 14, 2026

Copy link
Copy Markdown
Member

We discussed verbally that we want to introduce this exception because imaginary does not log anything (if there's no problem) with a log level above 'info', which we consider easily irritating for users.

@pabzm pabzm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the log should contain a note if the log level is 'warn' or 'error', that it gets ignored (like in the watchtower PR).

Signed-off-by: Simon L. <szaimen@e.mail.de>
@szaimen
szaimen requested a review from pabzm October 14, 2026 10:43
@szaimen

szaimen commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator Author

I think the log should contain a note if the log level is 'warn' or 'error', that it gets ignored (like in the watchtower PR).

Done

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants