Conversation
tty-13
commented
Jul 14, 2026
added 5 commits
July 14, 2026 15:08
Signed-off-by: tty13 <git@tty13.net>
Signed-off-by: tty13 <git@tty13.net>
Signed-off-by: tty13 <git@tty13.net>
Signed-off-by: tty13 <git@tty13.net>
Signed-off-by: tty13 <git@tty13.net>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
|
Hello there @tty-13 regards, Aal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello and thanks for the work on this collection, it's a great time-saver.
I saw the php config in the install role was directly written on the main php.ini file and thought it would be better to add all this config as modules, to make it clearer what has been changed by who.
I implemented a few tasks to bring this feature :
There's a general php module and a cli-specific one.
The normal config is loaded in
{ php_dir }/fpm/conf.d directory*with priority 50The cli config is loaded in
{ php_dir }/cli/conf.dwith priority 50Also, I saw fpm was only half-supported in the apache task, I added the corresponding apache modules and conf to be loaded accordingly, I guess that was missing since php-fpm gets installed instead of just php.
( a2enmod proxy_fcgi and setenvif, and a2enconf php{php_ver}-fpm )
*(without fpm support, the php module could also be loaded in apache2, didn't implement that though, since we would first have to add some options to let the user choose between php and php-fpm)
Would you accept this contribution ?
Have a nice day :)