Skip to content

feat(simple-editor): show additional actions inline - #5906

Closed
szaimen wants to merge 1 commit into
mainfrom
enh/noid/show-inline
Closed

szaimen wants to merge 1 commit into
mainfrom
enh/noid/show-inline

Conversation

@szaimen

@szaimen szaimen commented Apr 8, 2024 •

Copy link
Copy Markdown
Contributor
Before After
image image

@szaimen szaimen added 2. developing Work in progress design Related to design, interface, interaction design, UX, etc. enhancement New feature request labels Apr 8, 2024
@codecov

codecov Bot commented Apr 8, 2024 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/views/EditSimple.vue 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@szaimen
szaimen force-pushed the enh/noid/show-inline branch 2 times, most recently from daf2b37 to fc5e549 Compare April 8, 2024 12:40
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen
szaimen force-pushed the enh/noid/show-inline branch from fc5e549 to 357300d Compare April 8, 2024 12:41
@szaimen szaimen changed the title show additional actions inline feat(simple-editor): show additional actions inline Apr 8, 2024
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 8, 2024
@szaimen
szaimen marked this pull request as ready for review April 8, 2024 12:52

@miaulalala miaulalala left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jancborchardt jancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some actions are more important or relevant than others here. Showing all of them inline is a bit much and results in a lot of icons without text, which we want to avoid because it is not readily understandable for people who do not use the software every day. :)

  • Download and Copy is not as important as "Delete" and "Edit"
  • The actions belong more to "Edit" than they do to the close button at the top

That’s why I propose an adjustment like this:
calendar event

@szaimen

szaimen commented Apr 8, 2024

Copy link
Copy Markdown
Contributor Author

That’s why I propose an adjustment like this:
calendar event

Good idea to move them to the bottom! :)

@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 8, 2024
@SebastianKrupinski

Copy link
Copy Markdown
Contributor

Some actions are more important or relevant than others here. Showing all of them inline is a bit much and results in a lot of icons without text, which we want to avoid because it is not readily understandable for people who do not use the software every day. :)

* Download and Copy is not as important as "Delete" and "Edit"

* The actions belong more to "Edit" than they do to the close button at the top

@jancborchardt @nimishavijay do we still want to do this?

@st3iny

st3iny commented Sep 25, 2025 •

Copy link
Copy Markdown
Member

I like the idea of moving them to the bottom. However, the devil lies in the details ™️.

For recurring events we have two delete buttons: this and this+all-future. So we need to render either two buttons, show a menu still or come up with a second modal to let the user decide.

@SebastianKrupinski

Copy link
Copy Markdown
Contributor

Closing this in favour of #7491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress design Related to design, interface, interaction design, UX, etc. enhancement New feature request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants