feat(talk): record the conversation as the event's conference - #8951
Merged
SebastianKrupinski merged 1 commit intoSep 25, 2026
Merged
Conversation
Rikdekker
requested review from
GVodyanov,
SebastianKrupinski and
tcitworld
as code owners
September 19, 2026 13:32
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
|
Reference: #1758 |
SebastianKrupinski
force-pushed
the
feat/hybrid-meeting-toggles
branch
from
September 25, 2026 12:14
4478871 to
95b0e26
Compare
Assisted-by: Claude:claude-opus-5 Signed-off-by: Rikdekker <Rikdekker@users.noreply.github.com>
SebastianKrupinski
force-pushed
the
feat/hybrid-meeting-toggles
branch
from
September 25, 2026 12:30
95b0e26 to
1f269df
Compare
SebastianKrupinski
added
3. to review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Talk link was only stored in LOCATION, or appended to DESCRIPTION when LOCATION already held something. Neither says "this is where the meeting happens online", and for a hybrid meeting LOCATION is needed for the room the event takes place in.
Write the conversation to CONFERENCE (RFC 7986), which is the property meant for a virtual meeting URL. An earlier conversation is replaced rather than stacked, so an event keeps a single conference.
Talk currently only finds events whose call link is in LOCATION, so CONFERENCE alone would make a hybrid meeting invisible there. That is why the existing LOCATION/DESCRIPTION behaviour stays as it is — clients that do not read CONFERENCE keep working exactly as before. nextcloud/spreed#19472 adds the DESCRIPTION side in Talk.
Tested with the resulting calendar objects on Nextcloud 35.0.0 (Calendar 6.6.0-rc.2, Talk 25.0.0), with nextcloud/spreed#19472 applied: a meeting with a room in LOCATION and a conversation is found by Talk, and so is an online-only meeting. The replace-not-stack behaviour was verified against @nextcloud/calendar-js directly.
🤖 AI (if applicable)