Skip to content

refactor: remove dead css code - #8971

Merged
SebastianKrupinski merged 1 commit into
mainfrom
refactor/remove-dead-css
Sep 24, 2026
Merged

SebastianKrupinski merged 1 commit into
mainfrom
refactor/remove-dead-css

Conversation

@SebastianKrupinski

@SebastianKrupinski SebastianKrupinski commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • removed dead css code

  • Old UI styles that no longer render:

    • the inline calendar-sharing panel (sharing-section, shareWithList, share-menu, open-sharing, icon-share* buttons)
    • old repeat-editor fields (end-repeat-, repeat-option-set__repeat)
    • .modal--scheduler from before the free/busy rework
    • the shortcut-modal media query and unused settings classes
  • Selectors for removed libraries: every .multiselect* (NcMultiselect is gone in @nextcloud/vue 9), mx-* from vue2-datepicker in Booking.vue, and FullCalendar v3 names (fc-state-highlight, fc-day-number, fc-bgevent).

  • Unused classes in components: in AppointmentDetails, AttachmentsList, CalendarPicker, the Proposal views, PropertyTitleTimePicker and CheckedDurationSelect. Also most of RoomAvailabilityList's scoped block, which was a copy of RoomAvailabilityModal's styles.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski SebastianKrupinski self-assigned this Sep 23, 2026
@SebastianKrupinski
SebastianKrupinski requested review from odzhychko and removed request for GVodyanov and tcitworld September 23, 2026 15:35
@SebastianKrupinski SebastianKrupinski added the 3. to review Waiting for reviews label Sep 23, 2026
@codecov

codecov Bot commented Sep 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@odzhychko odzhychko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odzhychko
odzhychko added this pull request to stack #8974 September 24, 2026 08:44
}
}
}
.modal__content__header {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: I noticed during review, that this component is never used. Made #8973 to follow up on this.

@SebastianKrupinski
SebastianKrupinski merged commit 543ef04 into main Sep 24, 2026
32 checks passed
@SebastianKrupinski
SebastianKrupinski deleted the refactor/remove-dead-css branch September 24, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants