Skip to content

fix(editor): restore focus after closing event popover - #8985

Open
abhinavohri wants to merge 1 commit into
nextcloud:mainfrom
abhinavohri:fix/restore-new-event-focus
Open

abhinavohri wants to merge 1 commit into
nextcloud:mainfrom
abhinavohri:fix/restore-new-event-focus

Conversation

@abhinavohri

@abhinavohri abhinavohri commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • remember the focused element when the simple event editor opens
  • restore focus when the editor closes if the element is still available

Assisted-by: Codex:gpt-5
Signed-off-by: Abhinav Ohri <abhinavohri13@gmail.com>
@codecov

codecov Bot commented Sep 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@SebastianKrupinski

Copy link
Copy Markdown
Contributor

Hi @abhinavohri

The ticket you linked has nothing to do with the changes you made. The ticket is about the calendar creation menu.

@abhinavohri

Copy link
Copy Markdown
Contributor Author

Hi @SebastianKrupinski , my apologies I mixed up the issues.

I followed the steps in the #4127, and the focus went back to the + button. So I think that issue is already fixed.

If this change is still useful, should I open a new issue and update this PR to reference it, or would you prefer that I close the PR?

@SebastianKrupinski

Copy link
Copy Markdown
Contributor

@abhinavohri

I can't really tell if this PR is useful as I don't have a reference of an issue. What issue does this PR solve?

@abhinavohri

abhinavohri commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor Author

I can't really tell if this PR is useful as I don't have a reference of an issue. What issue does this PR solve?

When the simple editor is dismissed without creating an event, keyboard focus jumps to the top of the page. This PR returns focus to the element that was focused before the editor opened.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants