Repository navigation
Feature: Publish Collective as Static Website - #2769
code4candy wants to merge 26 commits into
Conversation
mejo-
left a comment
There was a problem hiding this comment.
Overall looks great 😊 I have some comments on the backend part, the frontend looks fine from reading the code.
|
|
||
| test.describe('Collective publish', () => { | ||
| test('admin can open publish modal', async ({ collective, navigation, page }) => { | ||
| await runOcc(['config:app:set', 'collectives', 'publish_enabled', '--value', 'true']) |
There was a problem hiding this comment.
Maybe it helps to move the runOcc command to beforeEach()? You seem to do it at the start of all tests anyway.
7cebf56 to
63fc23e
Compare
13eabe3 to
20f507c
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
mejo-
left a comment
There was a problem hiding this comment.
The changes in this PR look good now. Ideally you could merge the three commits into one and then it would be ready to be used as the base for future PRs to be merged into it from my side 😊
Signed-off-by: kayoshi <jo5cha@web.de> Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: kayoshi <jo5cha@web.de> Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: kayoshi <jo5cha@web.de> Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-sonnet-5
…json Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-sonnet-5
…h restriction Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-sonnet-5
9ca1098 to
37ee4ef
Compare
Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Melpo <melpomene@posteo.net>
Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-sonnet-5
feat(collectives-publish) build targz

📝 Summary
This is the first step towards the publishing feature, that we implement as part of the funding program Prototype Fund (get more information here: https://github.com/nextcloud-publish). This is not going to be merged after a first review, but works as intermediate working tree for the feature.
Description
To initiate the publication of a website, each Collective should have a Publish button that opens a modal window where the publishing process can subsequently be configured.
The page selection and configuration process itself is out of scope for this issue.
Acceptance Criteria
🖼️ Screenshots
🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)