Revert "fix: use built now function instead of manually creating date"

[hamza221]

discovered in #4521
reverts #4573

According to the pre-existing logic :
https://github.com/nextcloud/contacts/blob/fix/invalid-rev/src/services/checks/invalidREV.js#L24-L30
vcardtime is expected for v3 contacts and icaltime is expected for v4
With the reverted commit that was not respected. According to that logic even the repaired rev is wrong.

creating rev from unix timestamp or js date are both supported by the library so I don't see anything wrong with the old method imo

[codecov]

Codecov Report

❌ Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 10.58%. Comparing base (8075b3c) to head (f2fd8ac).
⚠️ Report is 38 commits behind head on main.

Files with missing lines	Patch %	Lines
src/services/checks/invalidREV.js	0.00%	3 Missing ⚠️
src/store/contacts.js	0.00%	3 Missing ⚠️
src/views/Contacts.vue	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #4609      +/-   ##
============================================
+ Coverage     10.56%   10.58%   +0.02%     
  Complexity      265      265              
============================================
  Files           123      123              
  Lines          5767     5775       +8     
  Branches       1262     1262              
============================================
+ Hits            609      611       +2     
- Misses         5035     5041       +6     
  Partials        123      123              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ChristophWurst]

Makes sense

[hamza221]

/backport to stable7.2

[SebastianKrupinski]

FYI, doing this will break contacts saving. The vcardtime does not seem to work properly in the updated ical.js.

I would recommend fixing the check instead, since its a 5 year old patch for a bug that probably does not exist anymore

[hamza221]

fixed in #4634