Skip to content

[stable7.2] fix: generate rev depending on card version - #4636

Merged
hamza221 merged 1 commit into
stable7.2from
backport/4634/stable7.2
Aug 22, 2025
Merged

hamza221 merged 1 commit into
stable7.2from
backport/4634/stable7.2

Conversation

@backportbot

@backportbot backportbot Bot commented Aug 22, 2025

Copy link
Copy Markdown

Backport of PR #4634

Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
@backportbot
backportbot Bot requested a review from AndyScherzinger August 22, 2025 15:00
@backportbot backportbot Bot added bug Something isn't working 3. to review Waiting for reviews labels Aug 22, 2025
@backportbot backportbot Bot added this to the v7.2.0 milestone Aug 22, 2025
@codecov

codecov Bot commented Aug 22, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 23.52941% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 10.71%. Comparing base (f430357) to head (77e223d).
⚠️ Report is 2 commits behind head on stable7.2.

Files with missing lines Patch % Lines
src/services/checks/invalidREV.js 0.00% 5 Missing and 2 partials ⚠️
src/store/contacts.js 0.00% 2 Missing and 2 partials ⚠️
src/models/contact.js 80.00% 1 Missing ⚠️
src/views/Contacts.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             stable7.2    #4636      +/-   ##
===============================================
+ Coverage        10.66%   10.71%   +0.04%     
  Complexity         265      265              
===============================================
  Files              122      122              
  Lines             5708     5712       +4     
  Branches          1256     1257       +1     
===============================================
+ Hits               609      612       +3     
- Misses            4976     4978       +2     
+ Partials           123      122       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hamza221
hamza221 merged commit e45b044 into stable7.2 Aug 22, 2025
44 checks passed
@hamza221
hamza221 deleted the backport/4634/stable7.2 branch August 22, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants